Conversation
dms-2024-i5-r4
NImeson
reviewed
Nov 12, 2025
NImeson
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
I have created a new Leeds BRCA importer to work with files uploaded from 2025 and after.
I have also done the provision that older Leeds handler import data from previous batches(before 2025) and new one (after 2025). This will resolve https://nhsd-jira.digital.nhs.uk/browse/NIT-365
Why?
The structure of the new batches and its data have got changed, so a new handler was needed.
How ?
By adding a new Leeds handler and its flow to import data. Also Import_all_brca_interactive.sh has been updated to manage two imports of Leeds data.
Testing?
QA counts match has been done with Fiona and she has approved.
Have also added tests for the new handler and test on old handler to show they all work as expected.
Anything else?
No