Skip to content

Conversation

@dlzhry2nhs
Copy link
Collaborator

@dlzhry2nhs dlzhry2nhs commented Feb 9, 2026

Summary

  • Routine Change

Simple architecture change to enable coding work to begin on the Lambda. Details of the ticket are no longer relevant, so will update in JIRA. Discussed with architect who was happy with the changes.

  • Adds a stream to the delta table
  • Adds a new MNS Publisher Lambda function which will read from the new delta stream

This approach minimises the number of new components we will need while ensuring that we are only publishing MNS events where the event was successfully persisted across the whole system i.e. the events table and delta.

Have raised a couple of questions, which I'm happy to look into under this PR or

Reviews Required

  • Dev

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all of the acceptance criteria of the ticket.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • If there were changes that are outside of the regular release processes e.g. account infrastructure to setup, manual setup for external API integrations, secrets to set, then I have checked that the developer has flagged this to the Tech Lead as release steps.
  • I have checked that no Personal Identifiable Data (PID) is logged as part of the changes.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2026

This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket:

VED-981

name = "imms-${local.resource_scope}-delta"
billing_mode = "PAY_PER_REQUEST"
hash_key = "PK"
stream_enabled = true
Copy link
Collaborator Author

@dlzhry2nhs dlzhry2nhs Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth putting the stream and publisher Lambda function behind a switch in terraform? We might want to have off by default in envs other than internal-qa, int, and prod, but allow a developer to switch on if working on a PR environment.

Otherwise could be a lot of noise for PDS with invalid testing patients from our pipeline runs?

@dlzhry2nhs dlzhry2nhs temporarily deployed to internal-dev-sandbox February 10, 2026 16:13 — with GitHub Actions Inactive
@dlzhry2nhs dlzhry2nhs temporarily deployed to internal-dev-sandbox February 10, 2026 16:15 — with GitHub Actions Inactive
@dlzhry2nhs dlzhry2nhs temporarily deployed to internal-dev-sandbox February 10, 2026 16:23 — with GitHub Actions Inactive
@dlzhry2nhs dlzhry2nhs temporarily deployed to internal-dev-sandbox February 10, 2026 16:29 — with GitHub Actions Inactive
@dlzhry2nhs dlzhry2nhs temporarily deployed to internal-dev-sandbox February 10, 2026 16:29 — with GitHub Actions Inactive
@dlzhry2nhs dlzhry2nhs force-pushed the feature/VED-981-create-mns-events-sqs-queue branch from fde53db to 35bde5f Compare February 10, 2026 16:32
@sonarqubecloud
Copy link

@dlzhry2nhs dlzhry2nhs temporarily deployed to internal-dev-sandbox February 10, 2026 16:44 — with GitHub Actions Inactive
@dlzhry2nhs dlzhry2nhs temporarily deployed to internal-dev-sandbox February 10, 2026 16:48 — with GitHub Actions Inactive
@dlzhry2nhs dlzhry2nhs deployed to internal-dev-sandbox February 10, 2026 16:49 — with GitHub Actions Active
@dlzhry2nhs dlzhry2nhs deployed to internal-dev February 10, 2026 16:52 — with GitHub Actions Active
@dlzhry2nhs dlzhry2nhs marked this pull request as ready for review February 10, 2026 16:57
@dlzhry2nhs dlzhry2nhs changed the title VED-981 SQS Queue for MNS feature VED-981 Add MNS Publisher base infrastructure Feb 10, 2026
@dlzhry2nhs dlzhry2nhs changed the title VED-981 Add MNS Publisher base infrastructure VED-981 Add base infrastructure for the MNS Publisher feature Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant