-
Notifications
You must be signed in to change notification settings - Fork 3
VED-981 Add base infrastructure for the MNS Publisher feature #1191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: staging/VED-16-mns-vacc-event-notifications
Are you sure you want to change the base?
VED-981 Add base infrastructure for the MNS Publisher feature #1191
Conversation
|
This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket: VED-981 |
| name = "imms-${local.resource_scope}-delta" | ||
| billing_mode = "PAY_PER_REQUEST" | ||
| hash_key = "PK" | ||
| stream_enabled = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth putting the stream and publisher Lambda function behind a switch in terraform? We might want to have off by default in envs other than internal-qa, int, and prod, but allow a developer to switch on if working on a PR environment.
Otherwise could be a lot of noise for PDS with invalid testing patients from our pipeline runs?
fde53db to
35bde5f
Compare
35bde5f to
c5eb35f
Compare
|



Summary
Simple architecture change to enable coding work to begin on the Lambda. Details of the ticket are no longer relevant, so will update in JIRA. Discussed with architect who was happy with the changes.
This approach minimises the number of new components we will need while ensuring that we are only publishing MNS events where the event was successfully persisted across the whole system i.e. the events table and delta.
Have raised a couple of questions, which I'm happy to look into under this PR or
Reviews Required
Review Checklist
ℹ️ This section is to be filled in by the reviewer.