Merged
Conversation
| # Use "rake build" to build the gem, see rake -T for all bundler rake tasks (and our own). | ||
| module NdrDevSupport | ||
| VERSION = '7.3.2' | ||
| VERSION = '7.3.3' |
Contributor
There was a problem hiding this comment.
Are we happy this is only a patch version change if we're dropping support for Ruby 3.0?
Contributor
Author
There was a problem hiding this comment.
I think so: Ruby 3.0 is EOL since 2024-04-23, and no longer used by any of our systems. The target version is "currently supported Ruby versions". (I've left in Ruby 3.1 support only because we run Ruby 3.1 regression tests for some projects.)
Contributor
There was a problem hiding this comment.
I think patch versions should be backward compatible, which this change wouldn't be. However, as you say, none of our systems are using 3.0, so agree a patch level bump is fine here.
ollietulloch
approved these changes
Aug 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Released changes:
Fixed
Changed