Conversation
bshand
force-pushed
the
feature/rails_81
branch
from
c42848a to
3c72f7c
Compare
kenny-lee-1
approved these changes
Jan 13, 2026
Contributor
kenny-lee-1
left a comment
kenny-lee-1
left a comment
There was a problem hiding this comment.
Looks ok to me.
Tested "This code will work as before for existing config/deploy.rb files on Bundler 2. But if the require 'bundler/capistrano' line is removed, the new behaviour will instead be introduced" on one of the external api era targets and it did as you said.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support Rails 8.1, Ruby 4.0
capistrano: Support bundler 4 with capistrano 2
Bundler 4 no longer provides capistrano 2 integrations; this PR recreates them, with modifications to support Bundler 4 (which e.g. no longer supports the long-deprecated
--deploymentflags tobundle install).I've left the original Bundler capistrano 2 tasks unchanged as far as possible, rather than trying to rewrite them more cleanly.
This code will work as before for existing
config/deploy.rbfiles on Bundler 2. But if therequire 'bundler/capistrano'line is removed, the new behaviour will instead be introduced when callingrequire 'ndr_dev_support/capistrano/ndr_model'. This means existing code will work as before, but projects can switch to the new behaviour before switching to Bundler 4 (which is the new default version with Ruby 4.0).