-
Notifications
You must be signed in to change notification settings - Fork 1
NPA-6154: Change the spec and Postman #299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
NPA-6154: Change the spec and Postman #299
Conversation
|
This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket: NPA-6154 |
03db0ab to
c53e8c6
Compare
|
This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket: NPA-6154 |
|
This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket: NPA-6154 |
|
This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket: NPA-6154 |
|
This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket: NPA-6154 |
ellie-bound1-NHSD
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to remove provision.actor.role from examples and in the postman as we are deprecating it. have added a few comments where to remove but applies too all places. Please remove 🙏
| value: '9000000019' | ||
| role: | ||
| - role: | ||
| coding: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the whole role object
So that we are not showing a deprecated property in our examples
so line 39 to 43 should be gone as that is what you have replaced with regulatory basis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
| @@ -45,9 +45,9 @@ ConsentSingleAdultChildRelationshipUnknownLegalBasisBundle: | |||
| type: RelatedPerson | |||
| role: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove role
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
| - code: parental-responsibility | ||
| display: Parental responsibility | ||
| system: https://fhir.nhs.uk/England/CodeSystem/England-NHSProxyLegalBasis | ||
| coding: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove role
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
| - code: parental-responsibility | ||
| display: Parental responsibility | ||
| system: https://fhir.nhs.uk/England/CodeSystem/England-NHSProxyLegalBasis | ||
| coding: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove role
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
| @@ -163,8 +170,8 @@ ConsentMultipleRelationshipsSinglePatientIncludePerformerPatientBundle: | |||
| value: '9000000021' | |||
| role: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove role
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
| @@ -93,9 +93,10 @@ ConsentMultipleRelationshipsSinglePatientIncludePerformerPatientBundle: | |||
| value: '9000000020' | |||
| role: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove role
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
| @@ -175,8 +187,8 @@ ConsentMultipleRelationshipsSinglePatientIncludePatientBundle: | |||
| value: '9000000022' | |||
| role: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove role
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
| @@ -123,8 +129,8 @@ ConsentMultipleRelationshipsSinglePatientIncludePatientBundle: | |||
| value: '9000000021' | |||
| role: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove role
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
| @@ -71,8 +71,8 @@ ConsentMultipleRelationshipsSinglePatientIncludePatientBundle: | |||
| value: '9000000020' | |||
| role: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove role
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
|
This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket: NPA-6154 |
| @@ -141,7 +147,7 @@ ConsentMultipleRelationshipsIncludePerformerBundle: | |||
| role: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove role
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove role
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
| identifier: | ||
| system: https://fhir.nhs.uk/Id/nhs-number | ||
| value: '9000000022' | ||
| role: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove role
| identifier: | ||
| system: https://fhir.nhs.uk/Id/nhs-number | ||
| value: '9000000022' | ||
| role: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove role
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
| identifier: | ||
| system: https://fhir.nhs.uk/Id/nhs-number | ||
| value: '9000000022' | ||
| role: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove role
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove role
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
| identifier: | ||
| system: https://fhir.nhs.uk/Id/nhs-number | ||
| value: '9000000017' | ||
| role: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove role
| system: "https://fhir.nhs.uk/Id/nhs-number" | ||
| value: "9000000017" | ||
| role: | ||
| - role: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove role
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove role
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
| @@ -25,10 +25,10 @@ ConsentAdultToAdultGuardianRequest: | |||
| start: "2026-02-11T14:30:00Z" | |||
| actor: | |||
| - role: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove role
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
|
This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket: NPA-6154 |
ellie-bound1-NHSD
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few performers are added back into postman
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would expect this to be different if following these docs -> https://nhsd-confluence.digital.nhs.uk/spaces/NPA/pages/874694621/How+to+update+Postman+Collections
| " }", | ||
| " },", | ||
| " \"dateTime\": \"2024-07-21T17:32:28Z\",", | ||
| " \"performer\": [", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is performer back?
|
This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket: NPA-6154 |
Pull Request
🧾 Ticket Link
https://nhsd-jira.digital.nhs.uk/browse/NPA-6154
📄 Description/Summary of Changes
🧪 Developer Testing Carried Out
🧪 Reviewer Testing Required
✅ Developer Checklist
NPA-XXXX: <short-description><type>/NPA-XXXX/<short-description>NPA-XXXX: <short-description>terraform,documentation) are added👀 Reviewer Checklist
🚀 Post-merge
After merging and deploying changes to the sandbox, Postman collection or spec examples please run the Run Postman
collection workflow.
This will run the tests within the collection to check that the sandbox is working as expected once deployed.