DIG-8380 Improve accessibility of error messages#374
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR rewrites the shared livewire/alerts.blade.php partial to use NHS.UK notification-banner / error-summary components, links validation errors in the summary to their corresponding form-field error spans (improving keyboard / screen-reader navigation), adds the partial to the questions view, and records the change in the changelog.
Changes:
- Replaces the old session/event-driven alert markup with NHS.UK notification-banner and error-summary patterns, including clickable anchors to
{field}-error-errorIDs. - Adds
alerts.success.genericandalerts.warnings.titletranslations and includes the alerts partial inquestions.blade.php. - Bumps the v1.0.16 changelog date and adds a bullet describing the accessibility improvement.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| resources/views/livewire/alerts.blade.php | Full rewrite of the alerts partial using NHS.UK banner / error-summary components and an @if/@elseif chain. |
| resources/views/livewire/questions.blade.php | Includes the alerts partial at the top of the questions view. |
| lang/en/alerts.php | Adds success.generic and warnings.title translation keys used by the new partial. |
| CHANGELOG.md | Updates the v1.0.16 release date and lists the accessibility improvement. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This reverts commit 0925d03.
Android63
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.