Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR back-ports a suite of patches from the
SlicerSALTfork to ShapePopulationViewer:Pending
Highlights
1. S-Rep Import & Parsing
<upSpoke>,<downSpoke>,<crestSpoke>elements, append into a singlevtkPolyData..srep.jsonvia MRML’svtkMRMLSRepStorageNodeand export usingvtkSRepExportPolyDataProperties.--srepfiles(-s) flag in the standalone viewer; validate extensions before loading..xml&.srep.jsonalongside.vtk/.vtp.2. Spokes & Fiducials Visualization
ExtractSpokes()andAttachCellType()produce line meshes with per-point cell-type arrays; automatically compute magnitude scalars for 3-component attributes..fcsvmarkups, compute point spacing to size spheres, tag each with a “Fiducial Index” scalar for coloring.m_FileDir/m_FileNameassignment so the Qt UI shows the right fiducial filename.3. Custom Colormap & CLI Enhancements
sRepColorMap.spvcmresource; auto-load into the gradient widget on S-Rep import.--srepfilesand--fiducialfilesoptions inShapePopulationViewer.cxx; enforce file-type checks.4. UI & Layout Refinements
QHBoxLayouttoQVBoxLayout, then to a grid, reorganizing “Add Directory”, “Add VTK/VTP”, “Add S-Rep”, “Add Fiducial” and CSV buttons for clearer grouping.QToolButtonwidgets (toolButton_Open_*,toolButton_Delete_*), simplifying layout and theming.5. Time-Series Loading & Playback
timeSeriesLoaderQTdisplays CSV tables viavtkDelimitedTextReader→vtkQtTableView, emits selected file sequences.QTimerfor ~200 ms autoplay loops.6. Bug Fixes
pushButton_VIEW_reset).This consolidation brings ShapePopulationViewer on par with the
SlicerSALTfork’s advanced S-Rep and time-series capabilities—ready for integration into our mainline.