Open
Conversation
Author
|
I have noted some other PRs and discussions about CMake. You can close this PR with no explanation, but here's my opinion:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this pull request, I ported NVBorad to the CMake build system. This enables the nvboard static library and simulations based on NVBoard to be configured and built with CMake. I added two
CMakeLists.txtfiles. One is under the NVBoard project directory, this builds the static library and is intended to be used byadd_subdirectory. Another is underexample, this is an example and a starting point for a NVBoard user to write his/her ownCMakeLists.txtto build a simulation based on NVBoard, The README is also updated to add the instructions of using CMake.I think CMake can be a better choice than Makefile because it has better IDE/toolchain support, and it also has better cross-platform compatibility. For experienced users, CMakeLists.txt also usually has better readability than Makefile.
Currently, I only tested the CMakeLists.txt files under Linux.