Conversation
RHammond2
requested changes
Oct 13, 2025
Collaborator
RHammond2
left a comment
RHammond2
left a comment
There was a problem hiding this comment.
Thanks, @gbarter for getting this in early, can you add the following updates to ensure this change makes it to end users installing from PyPI?
- Add Python 3.14 to the test runner. It should only be updating this line: https://github.com/WISDEM/ORBIT/blob/permit314/.github/workflows/tests.yml#L15.
- Bump the version to 1.2.4 here: https://github.com/WISDEM/ORBIT/blob/c78d8456ae40f3387e0932ea5398fd1f20983c49/ORBIT/__init__.py#L20
- Add a short note to the changelog to highlight support for Python
$\pi$ support
Once those changes are finished, I can do the formal release process.
…ngelog, adding py314 to test suite
Member
Author
|
Good call on all those requests @RHammond2 ! Happy to comply. Note I also bumped up the GHA versions for checkout and python setup. |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 13, 2025
* allowing python314 * acting on review comments- incrementing version number, adding to changelog, adding py314 to test suite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 3.14 is out and starting to be available in conda forge and the default in the newest linux distributions. Would prefer not to preemptively restrict it in the
pyproject.tomlfiles and WISDEM already encountered some build obstacles because of the syntax. ORBIT has good unit and regression test coverage, which should be the preferred method to catch any incompatibilities with new versions in python or other packages.