Merged
Conversation
…Bang Nguyen at NLR
…in an iterative optimization
…SDEM into feature/wombat-intregration
Feature: WOMBAT integration for optional OpEx calculation
Converter model from Sam Seo and Bang Nguyen at NLR
gbarter
approved these changes
Feb 18, 2026
Member
gbarter
left a comment
gbarter
left a comment
There was a problem hiding this comment.
THank you for pushing this forward!
Member
|
@dzalkind - Good to go here? |
dzalkind
reviewed
Feb 24, 2026
wisdem/glue_code/gc_WT_InitModel.py
Outdated
|
|
||
| if 'ROSCO' in modeling_options: # Will only be there if called by WEIS | ||
| if modeling_options['ROSCO']['ps_percent'] != control["pitch"]["ps_percent"]: | ||
| wt_opt["control.V_in"] = min(control["min_pitch_table"]["wind_speed"]) |
Contributor
There was a problem hiding this comment.
I suggest we incorporate a specific cut-in/cut-out wind speed because I made these tables in ROSCO, which uses some defined cut-in wind speed, sometimes coming from wisdem/weis, so it's a bit circular and unclear now where these should be set.
I prototyped an addition to the control geometry schema if we want it there, but I also think it could go under assembly. Thoughts? @ptrbortolotti
update to windIO 2.1.1, cut in and cut out in assembly block of geome…
Member
|
@ptrbortolotti - Good to go here? I think there is a cascade of releases/PRs after WISDEM aligns with WindIO v2.1. . . |
Contributor
|
I am good on the WEIS side: NLRWindSystems/WEIS#460 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Prep release 4.1.0
We should wait to merge this as @dzalkind tests this branch on WEIS
Type of change
Testing
Checklist