Improve the script (see each commit)

[kocoten1992]

Thank for the script, I have some commits to improve it.

There are two areas I wish to improve on but I'm out of juice right now:

1. try not to use /dev/sda instead use /dev/disk/by-id/<disk_id> (or /dev/disk/by-id/diska-part2), but in kvm environment, disk do not have it own id, so this approach do not work, it should be mention on readme with a command line to export and reimport using disk by-id on physical disk to improve zfs reliability (eg: /dev/sda could be /dev/sdb the on the next machine reboot - using by-id will prevent this).
2. mordenize /etc/apt/source.list, in debian 13, a new format is being use (via package modernize-sources), it would be good if include this fix.

Please ping me if anything is unclear, thank you!

P/s: forgot to mention, I use kvm to test this script, when using kvm with UEFI, configure UEFI without secure boot to prevent being block mobprobe zfs - maybe this should go to readme as well 😃 .

[kocoten1992]

I have a patch to keep the default for zpool create but not sure if you like it - the reason is to keep thing simple:

Technically, only ashift and xattr=sa is not changable after create zpool, other can be change (with the exception of acltype=posixacl - a bit more dificult but still possible).

I'd propose that only keep ashift and xattr=sa and keep the default for the rest - when user need they could enable/disable themself?

P/s: TIL xattr=sa can be change after create pool as well - with the same method as acltype=posixacl (recopy files).