Feature(#401): set seed for short term trend estimation

[atyrell3]

UNDER REVIEW. DO NOT MERGE!!!

Justification

Short term trend plotting was not reproducible last year, resulting in trend lines appearing/disappearing when plots were regenerated. This is caused by the bootstrapping in the arfit methods used to fit the short-term trend.

Fixes #401

Types of changes

• Fix (non-breaking change which fixes a bug)
• Feature (non-breaking change which adds or changes functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Other change (if none of the other choices apply)

Reviewer instructions

• Reinstall package
• Run the same ecodata::plot_** call with n = 10 multiple times to ensure short-term trend (or lack thereof) is reproducible. Suggest to use plot_comdat(varName = "revenue", n = 10) as this gave us trouble last year.

Formatting

This repo contains an air.toml file that automatically formats code to a set of standards.
It is preferred that contributors and reviewers install the Air formatting tool.
Code submitted in this pull request will be automatically checked for correct formatting.

[andybeet]

This all looks fine, but when i try switch to this branch, Rstudio wont let me and puts in a state where i am in "no branch" and when i try to switch back to dev i get fatal: not a git repository (or any of the parent directories): .git. and i am stuck! I think i need to reclone?

Not sure why this is happening, since the diff (from dev) is only one line in one file. However I am guessing this might be due to the fact this branch was a couple of years old and something funky happened when updating to dev? Anyone else having an issue like this? or is it just me?

EDIT: Ah, i see. It was due to an old branch. The .Rproj has been untracked in earlier PRs and this PR removed it. Had to create a new project in existing directory, then all was good.

[BBeltz1]

This all looks fine, but when i try switch to this branch, Rstudio wont let me and puts in a state where i am in "no branch" and when i try to switch back to dev i get fatal: not a git repository (or any of the parent directories): .git. and i am stuck! I think i need to reclone?

Not sure why this is happening, since the diff (from dev) is only one line in one file. However I am guessing this might be due to the fact this branch was a couple of years old and something funky happened when updating to dev? Anyone else having an issue like this? or is it just me?

EDIT: Ah, i see. It was due to an old branch. The .Rproj has been untracked in earlier PRs and this PR removed it. Had to create a new project in existing directory, then all was good.

Not quite. This PR is problematic. I've converted to a draft for now. Please suspend any actions until further notice. Thanks!

[atyrell3]

I cloned off of main this morning and updated the 1 file, not sure what is going on with the old pull requests and .Rproj

[BBeltz1]

I cloned off of main this morning and updated the 1 file, not sure what is going on with the old pull requests and .Rproj

Yes, this is what's causing the problems. A branch cloned from main cannot be merged into dev.

[atyrell3]

do you want me to open another pr with a different branch?

[BBeltz1]

I cloned off of main this morning and updated the 1 file, not sure what is going on with the old pull requests and .Rproj

Yes, this is what's causing the problems. A branch cloned from main cannot be merged into dev.

You'll need to branch off of dev, make the change again and then create a new PR merging from the new feature branch to dev.