post release action for version number + fix docs trigger#1055
Merged
Conversation
rem1776
requested review from
bensonr,
laurenchilutti,
thomas-robinson and
underwoo
| delete-branch: true # delete afer merge | ||
| title: Append dev to version number post-release | ||
| body: automated change, adds '-dev' to the version number upon releases | ||
| reviewers: rem1776 |
Member
There was a problem hiding this comment.
Is the reviewers required? Will rem1776 be the only required reviewer? This could cause a potentially dangerous situation if you're on leave or away at the time of a release and a backup person is required.
Contributor
Author
There was a problem hiding this comment.
i think it adds the other reviewers based on codeowners like it does for other prs, but i mean it's always the same changes so i'll just add you and rusty to that list
Member
There was a problem hiding this comment.
Can you get rid of reviewers entirely? Then it should just add the 3 of us, right?
laurenchilutti
previously approved these changes
Oct 17, 2022
laurenchilutti
approved these changes
Oct 17, 2022
thomas-robinson
approved these changes
Nov 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
adds an action that will submit a pull request automatically after releases in order to add the -dev suffix to the autotools version and then assign me to review + merge it.
This might require additional permissions in the github settings (mentioned in the action page), but in my testing I was able to do it with the default settings. It always makes a new branch (with a timestamp) so shouldn't affect anything else in the repo.
One caveat is that the auto-generated PR won't run the CI workflows (at least not without additional work + messing with the tokens). Doesn't really matter though since the actual release tag will already be getting tested in the CI whenever this runs.
There is also a small bug fix here for the documentation action, apparently github thought it was a good idea to count the
releasetrigger as three different events.How Has This Been Tested?
Here's the generated PR from my fork:
rem1776#50
i just made releases on my fork till it worked so it should be the same end result
Checklist:
make distcheckpasses