Skip to content

Clean up configure.ac and add workflow_dispatch to tag.yaml#401

Merged
ceblanton merged 2 commits into
NOAA-GFDL:mainfrom
mlee03:fix-release
May 7, 2026
Merged

Clean up configure.ac and add workflow_dispatch to tag.yaml#401
ceblanton merged 2 commits into
NOAA-GFDL:mainfrom
mlee03:fix-release

Conversation

@mlee03
Copy link
Copy Markdown
Contributor

@mlee03 mlee03 commented May 7, 2026

Description
In this PR, the following have been changed in configure.ac.

  • Bug fix: Corrected $RPATHFLAGS to $RPATH_FLAGS
  • Dead code removal: Removed the unused variable declarationvariable build_mpi=no
  • Style consistency: Replaced bare if/fi shell blocks with AS_IF macros in order to be consistent with the rest of the file.
  • Simplified xarray conditional: Replaced an if/else/fi block that called AM_CONDITIONAL in both branches with a single unconditional AM_CONDITIONAL call.
  • Indentation fixes: Corrected unindented macro calls inside several AS_IF bodies statements.
  • Minor: Added missing [] quoting around AC_MSG_WARN arguments; removed a stray leading space from a comment; removed a spurious space before dnl on AC_SUBST(RPATH_FLAGS).

Disclaimer: AI coding assistant was used to generate and implement solutions to the #402, and to write the initial draft of this PR summary

Fixes #402

How Has This Been Tested?
NA

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

@mlee03 mlee03 requested review from ceblanton, rem1776 and underwoo May 7, 2026 12:23
@mlee03 mlee03 marked this pull request as ready for review May 7, 2026 12:23
@mlee03 mlee03 changed the title Clean up configure.ac Clean up configure.ac and add workflow_dispatch to tag.yaml May 7, 2026
Copy link
Copy Markdown
Contributor

@ceblanton ceblanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I had to use AI to interpret both commits ha ha but they look great. Let's see if the manual dispatch works!

Copy link
Copy Markdown
Contributor

@rem1776 rem1776 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like good changes to me

@ceblanton ceblanton merged commit c0836a1 into NOAA-GFDL:main May 7, 2026
4 checks passed
Comment thread configure.ac
fi
AS_IF([test "$enable_gpu" = yes], [
AC_CHECK_HEADERS([openacc.h], [], [AC_MSG_ERROR([Cannot find OpenACC header file])])
AC_MSG_WARN([Currently only NVIDIA compilers are supported to compile with OpenACC in FRE-NCTOOLS])
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you didn't add this, but other compilers support openACC. This message should be changed. Introduction to OpenACC — OpenACC/CUDA for beginners https://enccs.github.io/OpenACC-CUDA-beginners/1.02_openacc-introduction/

Also, should configure fail if the user requested openACC,and configure was unable to find the header?

I understand this is outside the scope of this change, but these are things that should be addressed. Open new issues if these will be addressed outside this PR.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be better to search the compiler option space for the openACC option? Otherwise, the user will need to add to the [CF]FLAGS to compile with openACC.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the only GPU support openACC? If so, the configure option should be changed to reflect that. Enable-openacc instead of enable-gpu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add workflow_dispatch specification to tag.yaml

4 participants