Clean up configure.ac and add workflow_dispatch to tag.yaml#401
Conversation
ceblanton
left a comment
There was a problem hiding this comment.
Thank you! I had to use AI to interpret both commits ha ha but they look great. Let's see if the manual dispatch works!
rem1776
left a comment
There was a problem hiding this comment.
Looks like good changes to me
| fi | ||
| AS_IF([test "$enable_gpu" = yes], [ | ||
| AC_CHECK_HEADERS([openacc.h], [], [AC_MSG_ERROR([Cannot find OpenACC header file])]) | ||
| AC_MSG_WARN([Currently only NVIDIA compilers are supported to compile with OpenACC in FRE-NCTOOLS]) |
There was a problem hiding this comment.
I know you didn't add this, but other compilers support openACC. This message should be changed. Introduction to OpenACC — OpenACC/CUDA for beginners https://enccs.github.io/OpenACC-CUDA-beginners/1.02_openacc-introduction/
Also, should configure fail if the user requested openACC,and configure was unable to find the header?
I understand this is outside the scope of this change, but these are things that should be addressed. Open new issues if these will be addressed outside this PR.
There was a problem hiding this comment.
Wouldn't it be better to search the compiler option space for the openACC option? Otherwise, the user will need to add to the [CF]FLAGS to compile with openACC.
There was a problem hiding this comment.
Is the only GPU support openACC? If so, the configure option should be changed to reflect that. Enable-openacc instead of enable-gpu
Description
In this PR, the following have been changed in
configure.ac.$RPATHFLAGSto$RPATH_FLAGSvariable build_mpi=noif/fishell blocks withAS_IFmacros in order to be consistent with the rest of the file.Disclaimer: AI coding assistant was used to generate and implement solutions to the #402, and to write the initial draft of this PR summary
Fixes #402
How Has This Been Tested?
NA
Checklist:
make distcheckpasses