Open
Conversation
* return data from read function
* enable testing to run workflows for CI, which will use production Tiled but github actions, which will make using Prefect Cloud impractical
* do not need profiles to be mounted (not possible for CI anyways)
* no exceptions that prevented completion * used for CI test that returns end_of_run_workflow()
* this PR now incorporates the branch `refactor-tasks` and includes a minor print formatting change and removing the extra layer of flow
* fail gracefully if not available to enable easier workarounds for testing
* for CI, calling a function with the Tiled API key and stop document string would be convenient
* distinguish from any actual Tiled API key - this will go through end_of_run_workflow() kwargs when the module is called
* match what is used in workflow
* already included in lock file, so no update necessary
* read TILED_API_KEY in from env.secrets * a couple of other fix-ups
* remove from data_validation which is no longer used * update deployment file for current locations
* for testing
* set repo name to main so that these functions will run
in production
* CI, image build, and pre-commit ran fine so I am happy to
change this now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incorporates changes in #8
Refactor tasks and flows
Add a small testing function that will use a Tiled API key stored in the repo secrets to run the end_of_run_workflow() as a PyTest.
This has required some updates to make it work practically:
from_uri()instead offrom_profile()so that the testing does not depend on local files (Tiled site profiles - also need to add an environment variable to store the location)end_of_run_workflow()to signal that all of the steps completed successfullyAs of March 12, also updated to use new directory and filename for Tiled credentials, provide
dry_runoption (though minimally useful)