企画フレームの作成#120
Merged
Merged
Conversation
🩺 React Doctor |
⚡️ Lighthouse CI Results
|
Contributor
There was a problem hiding this comment.
Pull request overview
企画フレーム(EventFrame)コンポーネントを新規追加し、開発用ページで表示確認できるようにするPRです。
Changes:
EventFrame(カードUI + 文字数に応じた表示/省略 + 省略時Tooltip)を新規作成- 共通の
Tooltipコンポーネントにoffset指定を追加 - devページに
EventFrameのプレビューを追加
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/components/ui/EventFrame.tsx | 企画フレームUIを追加し、長い企画名は省略+Tooltipで全文表示 |
| src/components/aria/Tooltip.tsx | Tooltipの見た目を変更し、offset を外部指定可能に変更 |
| src/app/(frontend)/(dev)/dev/common/page.tsx | dev共通コンポーネント一覧にEventFrameプレビューを追加 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TkymHrt
reviewed
May 24, 2026
Member
TkymHrt
left a comment
There was a problem hiding this comment.
PRありがとー
動作や見た目も大丈夫そうです!
コード部分いくつかコメントしました。
Comment on lines
+29
to
+30
| <Link | ||
| href={href} |
Member
| className="flex h-[200px] w-[148px] flex-col rounded-lg bg-secondary pb-s shadow-[0px_6px_8px_rgba(60,224,232,0.6)] transition-all duration-200 hover:-translate-y-1 hover:shadow-[0px_6px_8px_rgba(60,224,232,1.0)]" | ||
| > | ||
| <div className="relative h-[111px] w-full shrink-0 overflow-hidden rounded-tl-lg rounded-tr-lg"> | ||
| <Image className="object-cover" src={imageUrl} alt={imageAlt} fill sizes="148px" /> |
Member
| }; | ||
|
|
||
| const MAX_LENGTH = 24; | ||
| const TEXTB_LENGTH = 14; |
Member
| className="flex h-[200px] w-[148px] flex-col rounded-lg bg-secondary pb-s shadow-[0px_6px_8px_rgba(60,224,232,0.6)] transition-all duration-200 hover:-translate-y-1 hover:shadow-[0px_6px_8px_rgba(60,224,232,1.0)]" | ||
| > | ||
| <div className="relative h-[111px] w-full shrink-0 overflow-hidden rounded-tl-lg rounded-tr-lg"> | ||
| <Image className="object-cover" src={imageUrl} alt={imageAlt} fill sizes="148px" /> |
TkymHrt
reviewed
May 27, 2026
| href="/" | ||
| imageUrl="/icon/Instagram.png" | ||
| /> | ||
| <EventFrame name="あいうえおかきくけこさしすせそ" href="/" imageUrl="dummy.png" /> |
Member
There was a problem hiding this comment.
存在しない画像渡しているからエラーでてる
動作確認までお願いね~
TkymHrt
approved these changes
May 27, 2026
tsukachan-24
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

概要
変更点
関連Issue
スクリーンショット(UI変更がある場合)
動作確認手順
1.src/app/(frontend)/(dev)/dev/common/page.tsxで確認
2.
レビューしてほしいポイント
セルフチェックリスト