マップフレームの作成#121
Open
oniwawa wants to merge 19 commits into
Open
Conversation
🩺 React Doctor |
⚡️ Lighthouse CI Results
|
TkymHrt
reviewed
May 27, 2026
Member
TkymHrt
left a comment
There was a problem hiding this comment.
PRありがとうございます!
コードベースだけレビューしました。
細かいところですが、コメントしてます。
Collaborator
|
ありがとうございます! そのほかのデザインはOKです! |
Contributor
Author
|
指摘貰った修正箇所を修正し、py-4pxで実装しました |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
変更点
-MapFrameコンポーネントを作成し、以下のpropsを設定しました
imageSrc:画像のURLを入力、未入力の場合「MAP NO IMAGE」の文字が表示される
alt:画像のalt
title:枠外の水色の部分の文字を入力、未記入の場合は表示されない
type:shortで短いタイトル、longで長いタイトルの長さを指定
関連Issue
#116
スクリーンショット(UI変更がある場合)
動作確認手順
レビューしてほしいポイント
セルフチェックリスト