[fix] 場所一覧デザインをFigmaに合わせる#58
Draft
screana wants to merge 9 commits into
Draft
Conversation
🩺 React Doctor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
Figma の場所一覧デザインに合わせて、管理者画面の場所一覧 UI を調整しました。
左上ロゴは今回の対象外として変更していません。
変更点
ChevronRight/ChevronDownの切り替えに変更size-4に整理対象コミット
7fe2df9[fix] React Doctor指摘のサイズ指定を整理76376db[fix] タスク一覧の冗長なARIA指定を整理ed549e6[chore] 未使用依存関係の指摘を整理ff4924c[chore] pnpmの依存取得ポリシーを設定4ddf69d[fix] 認証ロールの公開API意図を明示変更内容
w-N h-Nのような同一サイズ指定をsize-Nに置き換え<ul role="list">の冗長な role を削除role="status"を semantic な<output>に変更@radix-ui/react-visually-hiddendate-fnssupabaseCLI はpackage.jsonの script に追加し、devDependency として使う意図を明示@supabase/supabase-jsは Supabase client の戻り値型として明示pnpm-workspace.yamlに依存取得ポリシーを追加minimumReleaseAge: 10080trustPolicy: no-downgraderequireUserWithRolesとAPP_ROLE_VALUESは将来利用を見込む公開 API として export を残し、React Doctor の未使用 export 指摘だけ明示的に抑制スクリーンショット
確認対象画面:
/admin/locations動作確認手順
pnpm devでアプリを起動する/admin/locationsを開く実行済みチェック:
pnpm typecheckpnpm lintレビューしてほしいポイント
- Figma の場所一覧デザインと比べて、余白・階層インデント・行の見た目に違和感がないか