fix(playback): sync play/pause button with media keys - #43
Open
mihaimetal wants to merge 2 commits into
Open
Conversation
mihaimetal
force-pushed
the
fix/media-key-play-pause-ui
branch
from
July 27, 2026 13:43
7bddad5 to
1d3fe0b
Compare
Author
|
Rebased onto current |
7 tasks
mihaimetal
force-pushed
the
fix/media-key-play-pause-ui
branch
from
August 2, 2026 07:48
1d3fe0b to
6f05b94
Compare
macOS media keys (F8) often toggle the WebKit <audio> element directly without going through our store. Mirror element play/pause events into playing so the UI icon stays correct, and suppress that sync briefly during intentional track-switch pauses.
Register navigator.mediaSession action handlers so WKWebView routes hardware previous/next while HTML audio is playing, and attach skip commands on MPRemoteCommandCenter (no Accessibility / event taps). Also debounce skip paths and keep Media Session metadata in sync with souvlaki Now Playing updates.
mihaimetal
force-pushed
the
fix/media-key-play-pause-ui
branch
from
August 2, 2026 18:27
6f05b94 to
8866611
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<audio>element directly instead of going through the souvlakimedia-controlpath, so sound changed but the store’splayingflag (and thus the button) did not.play/pauseevents into the playback store.playing: true.Test plan
Notes
Independent of the WEB_REMIX / auth / packaging PRs; can merge on its own against
main.