docs: replace obsolete --experiment-dir with --result-dir in SLURM guide (#1128)#1654
Open
rtmalikian wants to merge 1 commit into
Open
docs: replace obsolete --experiment-dir with --result-dir in SLURM guide (#1128)#1654rtmalikian wants to merge 1 commit into
rtmalikian wants to merge 1 commit into
Conversation
The --experiment-dir parameter was removed from train_evo2 in PR NVIDIA-BioNeMo#740. Replace the last remaining reference in the SLURM documentation with the current --result-dir parameter, using the existing RESULTS_PATH variable for consistency. Fixes NVIDIA-BioNeMo#1128
rtmalikian
requested review from
jstjohn,
jwilber,
polinabinder1,
pstjohn,
trvachov and
yzhang123
as code owners
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
--experiment-dirparameter was removed fromtrain_evo2as part of PR #740, but one reference remained in the SLURM documentation.What was broken
The SLURM guide contained an obsolete
--experiment-dirparameter in the example training command (line 90). Users following this guide would get an unknown parameter error.What the fix does
Replaces
--experiment-dir=/workspace/bionemo/model/checkpoints/${EXPERIMENT_NAME}with--result-dir=${RESULTS_PATH}, which:--result-dir)RESULTS_PATHvariable for consistency with the rest of the scriptVerification
--result-diris the current parameter inrecipes/evo2_megatron/src/bionemo/evo2/run/train.py:315--experiment-dirremain in the codebaseRESULTS_PATHvariable is already defined at line 62 of the same fileFixes #1128
About the Author: Raphael Malikian — Clinical AI Solutions Architect. I specialise in building and fixing AI/ML systems for healthcare, including vector databases, RAG pipelines, and clinical NLP. If you need help with your project or think I can add value to your organisation, feel free to reach out — I'd love to connect.
📧 rtmalikian@gmail.com
🔗 GitHub: https://github.com/rtmalikian
🔗 LinkedIn: http://www.linkedin.com/in/raphael-t-malikian-mbbs-bsc-hons-71075436a
Disclosure: This code was developed with assistance from mimo-2.5-pro (Xiaomi) via Hermes Agent (Nous Research). All changes were reviewed, tested against the actual codebase, and verified for correctness.