Skip to content

beep boop 🤖: Bumping Emerging-Optimizers to v0.2.1 #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nemo-automation-bot wants to merge 2 commits into
base: fake-release/f04084fd-9683-4113-b40a-d2a36699026a
Choose a base branch
from
Open

beep boop 🤖: Bumping Emerging-Optimizers to v0.2.1 #195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48c060b
ci: pin FW-CI-templates to NVIDIA-NeMo/FW-CI-templates#480 (mirror br…
ko3n1g May 22, 2026
049158d
beep boop 🤖: Bumping Emerging-Optimizers to v0.2.1 [skip ci]
github-actions[bot] May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ jobs:
!cancelled() && !failure()
&& !(needs.pre-flight.outputs.docs_only == 'true'
|| needs.pre-flight.outputs.is_deployment_workflow == 'true')
uses: NVIDIA-NeMo/FW-CI-templates/.github/workflows/_release_library.yml@v1.1.0
uses: NVIDIA-NeMo/FW-CI-templates/.github/workflows/_release_library.yml@a2d0fba9aaaf595d9bb3a0e8f3e71461983e0f15
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Pinning to a commit SHA is good practice for supply-chain security, but without an inline comment the SHA is opaque — it's impossible to tell at a glance what version of _release_library.yml is in use, which makes future audits and upgrades harder. Adding a comment with the corresponding tag name keeps the security benefit while restoring readability. Note also that _cicd_preflight.yml on line 75 is still referenced via a mutable tag (@v0.94.1), so the two workflow references are now inconsistent.

Suggested change
uses: NVIDIA-NeMo/FW-CI-templates/.github/workflows/_release_library.yml@a2d0fba9aaaf595d9bb3a0e8f3e71461983e0f15
uses: NVIDIA-NeMo/FW-CI-templates/.github/workflows/_release_library.yml@a2d0fba9aaaf595d9bb3a0e8f3e71461983e0f15 # v1.1.0

with:
release-ref: ${{ inputs.release-ref || github.sha }}
python-package: emerging_optimizers
Expand Down
2 changes: 1 addition & 1 deletion emerging_optimizers/package_info.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

MAJOR = 0
MINOR = 2
PATCH = 0
PATCH = 1
PRE_RELEASE = ""

# Use the following formatting: (major, minor, patch, pre-release)
Expand Down