ci: add GitLab container build config for dev/0.3.0 (public containers)#1015
Open
wprazuch wants to merge 2 commits into
Open
ci: add GitLab container build config for dev/0.3.0 (public containers)#1015wprazuch wants to merge 2 commits into
wprazuch wants to merge 2 commits into
Conversation
When GitLab's pull-mirror updates dev/0.3.0 from GitHub, this triggers the full CI pipeline (containers, lint, test) on nv-internal-main. The actual CI config lives on nv-internal-main (internal, not mirrored). This file is the public bridge that makes internal container builds fire automatically on every public push. Signed-off-by: Wojciech Prazuch <wprazuch@nvidia.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Previous version used trigger:branch:nv-internal-main which was wrong —
it ran the pipeline in nv-internal-main context, building internal-tagged
containers from nv-internal-main code.
Correct approach: the container build jobs run directly on dev/0.3.0,
so CI_COMMIT_BRANCH = 'dev/0.3.0' and containers are tagged dev-{ts}-{sha}
from the public dev/0.3.0 code. Nothing in this file is sensitive —
all credentials come from GitLab CI/CD project variables at runtime.
Note: harbor excluded from public builds (internal infra). The full
variant set (lm-eval, skills, gym, full) remains.
Signed-off-by: Wojciech Prazuch <wprazuch@nvidia.com>
wprazuch
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
.gitlab-ci.ymlto the publicdev/0.3.0branch so GitLab builds public dev containers whenever the pull-mirror syncs from GitHub.Why the previous approach was wrong
The original PR used
trigger: branch: nv-internal-main. That would run the pipeline in nv-internal-main context (CI_COMMIT_BRANCH = nv-internal-main) and buildinternal-{ts}-{sha}containers from internal code — wrong.Correct approach
Container build jobs run directly on dev/0.3.0:
CI_COMMIT_BRANCH = "dev/0.3.0"dev-{ts}-{sha}_internal/additions)Two container builds, two branches
dev/0.3.0dev-{ts}-{sha}nv-internal-maininternal-{ts}-{sha}Nothing sensitive in this file
All credentials (
CI_REGISTRY_USER,CI_REGISTRY_PASSWORD,CI_REGISTRY) come from GitLab CI/CD project variables at runtime — not hardcoded here. Runner tags (nv-core-evals-x86) are just names.Note:
harborvariant excluded (internal infra). Public variants: base, lm-eval, skills, gym, full.For instant container builds
After merging: enable "Trigger pipelines for mirror updates" in GitLab → Settings → Repository → Mirroring repositories. Without it, containers build on the next 30-min mirror cadence.