fix(pre-commit): preserve matched filenames in no-underscore-md hook#458
Open
ooooo-create wants to merge 1 commit into
Open
fix(pre-commit): preserve matched filenames in no-underscore-md hook#458ooooo-create wants to merge 1 commit into
no-underscore-md hook#458ooooo-create wants to merge 1 commit into
Conversation
Signed-off-by: ooooo <3164076421@qq.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes a subtle argument-passing bug in the template’s local no-underscore-md pre-commit hook so all matched Markdown filenames are correctly preserved and reported.
Changes:
- Pass
--tobash -cso the first matched filename isn’t consumed as$0. - Add an inline comment documenting the
bash -cargument behavior and why--is required.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without
--, the first matched filename is treated as$0bybash -c, which means the hook can fail without reporting every offending Markdown file.--tobash -cin theno-underscore-mdlocal pre-commit hookI found this issue in NVIDIA-NeMo/Automodel@a409ff1#diff-63a9c44a44acf85fea213a857769990937107cf072831e1a26808cfde9d096b9 , and verified the fix in the
NVIDIA-NeMo/Automodel.Because I noticed that several repositories under
NVIDIA-NeMouse this hook, I came across this repository as well. I'd be happy to submit the same fix to other affected repositories too.