Skip to content

Fixed packing error #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
berserkr wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixed packing error #182

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa41a84
Fixed packing error
May 2, 2026
2f8c2fe
Merge branch 'main' into packing_fix_pr
marcromeyn May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/nemotron/data_prep/utils/splits.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,8 +175,12 @@ def realize_packed_shards_into_split_dirs(
logger.warning(f"Shard file not found: {parquet_path_str}")
continue

# Create symlink in split dir
link_path = split_dir / parquet_path.name
# Prefix symlink with dataset name to avoid collisions: multiple
# datasets produce identically-named shards (shard_000000.parquet, etc.),
# so bare filenames cause later datasets to overwrite earlier ones.
# Path convention: .../datasets/{dataset_name}/{plan_hash}/shard_NNNNNN.parquet
dataset_name = parquet_path.parent.parent.name
link_path = split_dir / f"{dataset_name}_{parquet_path.name}"

if link_path.exists() or link_path.is_symlink():
# Remove existing link/file to update
Expand Down