Fix shared memory Table size and accesses reporting in GUPS benchmark#60
Merged
harrism merged 2 commits intoNVIDIA-developer-blog:masterfrom Sep 23, 2025
Merged
Conversation
Based on feedback from rkarim2 in issue NVIDIA-developer-blog#56: - For shared memory tests, Table size now shows the actual total shared memory used - Display shared memory allocation details (bytes per block × number of blocks) - Use correct accesses_per_elem_sh for shared memory tests - Report size in MB for shared memory vs GB for global memory This fixes the misleading Table size output that showed irrelevant global memory sizes (e.g., 4.2 GB) when running shared memory tests.
|
Remove the comment on line 497 |
harrism
approved these changes
Sep 22, 2025
Removed the comment on line 497 as requested by rkarim2 in PR review.
Contributor
Author
Done. I'd like to offer a follow-up README fix to this: #61 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the incorrect Table size and accesses per thread reporting for shared memory tests in the GUPS benchmark, addressing the issues raised by @rkarim2 in #56.
Problem
Previously, when running shared memory tests, the benchmark incorrectly reported:
Solution
grid * n_shmem * sizeof(benchtype))accesses_per_elem_shfor shared memory tests instead ofaccesses_per_elemExample output
Before:
After:
Testing
make clean && makeAddresses the confusion mentioned in #56 about the misleading Table size output for shared memory tests.
Note: This is a clean PR with only the relevant changes, created from the latest master branch.