Implement energon prepare with a remote dataset (using local temp)#221
Implement energon prepare with a remote dataset (using local temp)#221voegtlel wants to merge 5 commits into
Conversation
8c093f4 to
70caf01
Compare
|
I see There's also a TODO in that method:
|
9905571 to
9cca0d0
Compare
|
@radulescupetru sorry for taking a while, had other priorities. Now also implemented that for filesystem:// links. Can you try again? |
9cca0d0 to
6a3b40c
Compare
25a9d35 to
598db74
Compare
…path handling. Fix S3 emulator timestamp handling
582a007 to
ac7dc96
Compare
| # Prefix to be removed from found paths to remap to relative paths | ||
| root_prefix = self._internal_str_path.lstrip("/") | ||
|
|
||
| for obj in self.fs.list_recursive(self._internal_str_path): |
There was a problem hiding this comment.
Either us or MSC team needs to fix this for local paths. This is way slower than os.walk. Maybe for now we should have os.walk here explicitly for local paths. In MSC they do os.listdir + sorting + isdir/isdile plus object construction for each file, i.e. lots of overhead.
But let's make sure we still preserve DSS URLs when using os.walk.
|
|
||
| owns_remote_sqlite_tmp = False | ||
| remote_sqlite_tmp_dir: Optional[Path] = None | ||
| if not parent_path.is_local(): |
There was a problem hiding this comment.
This will evaluate to True for DSS caches, because they are local. Can we maybe catch the read-only case somewhere early to get a useful error? (also for the other prepare entry points)
Fixes #91
Implements energon prepare for remote (including media metadata preparation)