Skip to content

Removed unneeded sqlite index. #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
voegtlel merged 4 commits into from
May 4, 2026
Merged

Removed unneeded sqlite index. #224

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9905394
Removed unneeded sqlite index.
bbuschkaemper Apr 15, 2026
c8bb7ac
Improved unit test by removing hardcoded auto-generated index name.
bbuschkaemper Apr 15, 2026
92fc14a
Remove unneeded unit test for webdataset indexing.
bbuschkaemper May 4, 2026
511f362
Merge branch 'develop' into remove-duplicate-sqlite-key
bbuschkaemper May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/megatron/energon/flavors/webdataset/indexing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,10 +237,7 @@ def close(self):

if self.enable_sample_tables:
# Create the index after adding all the samples for better speed
# Index on sample_key for fast lookups
self.db.execute(
"CREATE UNIQUE INDEX IF NOT EXISTS idx_samples_sample_key ON samples(sample_key)"
Comment thread
bbuschkaemper marked this conversation as resolved.
)
# sample_key uniqueness already creates an implicit SQLite index via the table schema.

# Create index on the samples table. Help the planner if it chooses `samples` as the probe side of the join
self.db.execute(
Expand Down
Loading