Fix _checkpointed_forward missing padding_mask parameter#4966
Closed
factnn wants to merge 1 commit into
Closed
Conversation
_checkpointed_forward() was missing the padding_mask parameter that the call site passes (added in NVIDIA#2645). The refactor in NVIDIA#4593 did not include it in the new signature, causing TypeError on the recompute path. Add padding_mask to the method signature, custom_forward closure, and both checkpoint call sites. Fixes NVIDIA#4933
Contributor
|
Thanks for your PR! Our colleague was a bit faster with #4963, so let's close this (and mine) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_checkpointed_forward()inMultiTokenPredictionLayerwas missing thepadding_maskparameter that the call site passes (added in #2645). The refactor in #4593 did not include it in the new signature, causingTypeErroron the recompute path (recompute_granularity == 'full').Changes
Add
padding_maskto:_checkpointed_forward()method signaturecustom_forwardclosure signature and its call to_proj_and_transformer_layerte_checkpointandtensor_parallel.checkpointpositional arg listsFixes #4933