Skip to content

chore: Set status on OTel spans#221

Draft
dagardner-nv wants to merge 20 commits into
NVIDIA:mainfrom
dagardner-nv:david-lc-04-observe
Draft

chore: Set status on OTel spans#221
dagardner-nv wants to merge 20 commits into
NVIDIA:mainfrom
dagardner-nv:david-lc-04-observe

Conversation

@dagardner-nv
Copy link
Copy Markdown
Contributor

Overview

WIP: Incomplete RFC draft

  • I confirm this contribution is my own work, or I have the right to submit it under this project's license.
  • I searched existing issues and open pull requests, and this does not duplicate existing work.

Details

Where should the reviewer start?

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • Closes #

Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
…otel specific attributes to metadata

Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
@dagardner-nv dagardner-nv self-assigned this Jun 4, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 4, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 4698ed11-8514-4dd4-87ad-655168ed43a9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added size:M PR is medium Maintenance CI or Build or general repository maintenance lang:python PR changes/introduces Python code lang:rust PR changes/introduces Rust code labels Jun 4, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2026

Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
@willkill07 willkill07 added this to the 0.4 milestone Jun 4, 2026
Signed-off-by: David Gardner <dagardner@nvidia.com>
@github-actions github-actions Bot added size:L PR is large lang:js PR changes/introduces Javascript/Typescript code and removed size:M PR is medium labels Jun 4, 2026
…ay.h is allowed/preferred, if it is we should drop nemo_relay_pop_scope_with_metadata and just add the new arg to nemo_relay_pop_scope [skip ci]

Signed-off-by: David Gardner <dagardner@nvidia.com>
@github-actions github-actions Bot added size:XL PR is extra large lang:go PR changes/introduces Go code and removed size:L PR is large labels Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lang:go PR changes/introduces Go code lang:js PR changes/introduces Javascript/Typescript code lang:python PR changes/introduces Python code lang:rust PR changes/introduces Rust code Maintenance CI or Build or general repository maintenance size:XL PR is extra large

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants