Skip to content

Conversation

@tarcila
Copy link
Collaborator

@tarcila tarcila commented Jan 25, 2026

Changed the overlay from a separate top-level window to a child window within the viewport. This ensures the overlay is properly occluded when other windows are docked on top of the viewport. Otherwise, other windows such the tranfer function editor would render behind the overlay.

image

Changed the overlay from a separate top-level window to a child window
within the viewport. This ensures the overlay is properly occluded when
other windows are docked on top of the viewport. Otherwise, other windows
such the tranfer function editor would render behind the overlay.
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR changes the viewport overlay rendering approach to fix z-ordering issues with docked windows. The overlay is converted from a standalone top-level window to a child window within the viewport, ensuring it's properly hidden when other windows (like the transfer function editor) are docked on top.

Changes:

  • Removed separate overlay window implementation and replaced it with a child window
  • Relocated overlay rendering and menu bar positioning in the build UI flow
  • Added window flags to prevent scrolling in the viewport

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
tsd/src/tsd/ui/imgui/windows/Viewport.h Removed the m_overlayWindowName member variable no longer needed for child window implementation
tsd/src/tsd/ui/imgui/windows/Viewport.cpp Refactored overlay from top-level window to child window, updated positioning logic, and adjusted rendering order

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jeffamstutz
Copy link
Collaborator

Nice -- LGTM, thanks!

@jeffamstutz jeffamstutz merged commit 376964f into NVIDIA:next_release Jan 26, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants