CI: Modernize CI workflow triggers and PR comment formatting.#163
Open
brycelelbach wants to merge 2 commits intomainfrom
Open
CI: Modernize CI workflow triggers and PR comment formatting.#163brycelelbach wants to merge 2 commits intomainfrom
brycelelbach wants to merge 2 commits intomainfrom
Conversation
- Add `merge_group` trigger for GitHub merge queue support. - Replace `pull_request` trigger with `push` to all branches (excluding merge queue branches) to avoid redundant runs while still triggering CI on every push, even before a PR exists. Fork PRs are handled via NVIDIA's copy-pr-bot which copies code to `pull-request/N` branches. - Add concurrency groups to cancel superseded runs on the same branch. - Use `nv-gha-runners/get-pr-info` to resolve PR numbers on copy-pr-bot branches, with `workflow_run.pull_requests` as fallback for same-repo PRs. - Capture specific failure output (lychee report, notebook format errors, yamllint errors) and include in PR comments via collapsible details. - Unify artifact upload/download pattern across all test and PR comment workflow pairs.
- Fix invalid YAML caused by unindented template literal content in script blocks; use .replace().trim() to dedent at runtime. - Normalize comment headings: "YAML Lint Check" → "YAML Check", "Commit Signature Check" → "Git Signature Check". - Unify section heading levels (all ### for "How to fix"). - Add missing external doc links to notebook-format and git-lfs comments. - Wrap git-lfs and git-signatures error details in collapsible <details> blocks, matching the pattern used by the other three comment workflows.
brycelelbach
force-pushed
the
feature/modernize-ci-workflows
branch
from
3324dc8 to
7334181
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
merge_grouptrigger for GitHub merge queue support.pull_requesttrigger withpushto all branches (excludinggh-readonly-queue/**merge queue branches) to avoid redundant duplicate runs while still triggering CI on every push, even before a PR exists. Fork PRs are handled via NVIDIA's copy-pr-bot which copies code topull-request/Nbranches.nv-gha-runners/get-pr-infoto resolve PR numbers on copy-pr-bot branches, withworkflow_run.pull_requestsas fallback for same-repo PRs.<details>blocks.