Container Toolkit 1.18.0 release notes - #242
Conversation
Documentation preview |
b028a5b to
b3558b1
Compare
|
@elezar are there any "Enhancements to libnvidia-container" for this release? |
When compared to v1.17.0 there are some fixes that were backported to the maintenance branch: https://github.com/NVIDIA/libnvidia-container/releases/tag/v1.18.0-rc.1 |
|
I will have a look at this PR and add some more inputs in the coming days. |
|
@a-mccarthy could we cherry-pick #203 here? |
I have already done it. |
a-mccarthy
left a comment
There was a problem hiding this comment.
@elezar and @ArangoGutierrez thanks for working on this! I added a few small nits/questions, but otherwise, looks good :)
| been resolved for some time now. The inclusion of this hook can still be | ||
| triggered when explicitly generating CDI specifications. | ||
| - The `legacy` mode of the NVIDIA Container Runtime is deprecated. It is no longer the _default_ mode | ||
| when using the `nvidia-container-runtime` is used. It is still supported for use cases where it is |
There was a problem hiding this comment.
Are there specific use cases for when its required? This seems a little vague to me for cases where the legacy mode is supported.
There was a problem hiding this comment.
This is intentionally vague, but I can add more context if you think it would help. Places where legacy mode is required / used:
- The
--gpusflag is used in Docker without invoking thenvidiaruntime (either as an explicit flag or as the default runtime). - A user has explicitly specified
legacyas the NVIDIA Container Runtime mode. - Use cases such as
enrootthat invoke thenvidia-container-clidireclty. - When using CRI-O with an on-disk OCI prestart hook.
- In the case of the GPU Operator where the
legacyruntime handler is explicitly requested.
There was a problem hiding this comment.
thanks for clarifying. Its probably ok to leave as is
|
@ArangoGutierrez pointed out that we need to update the documentation on configuring |
Signed-off-by: Andrew Chen <andrewch@nvidia.com>
Signed-off-by: Andrew Chen <andrewch@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Andrew Chen <andrewch@nvidia.com>
Co-authored-by: Abigail McCarthy <20771501+a-mccarthy@users.noreply.github.com> Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
ArangoGutierrez
left a comment
There was a problem hiding this comment.
Drop-in files addition
LGTM
* initial draft of release notes and version updates Signed-off-by: Andrew Chen <andrewch@nvidia.com> * update release notes w/ feedback from elezar@ Signed-off-by: Andrew Chen <andrewch@nvidia.com> * Release note updates Signed-off-by: Evan Lezar <elezar@nvidia.com> * Add documentation for the systemd nvidia-container-toolkit.service (#203) Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com> * Update CDI service instructions Signed-off-by: Evan Lezar <elezar@nvidia.com> * fix typos Signed-off-by: Andrew Chen <andrewch@nvidia.com> * Changes for style guide compliance Signed-off-by: Andrew Chen <andrewch@nvidia.com> * Update container-toolkit/release-notes.md Co-authored-by: Abigail McCarthy <20771501+a-mccarthy@users.noreply.github.com> Signed-off-by: Evan Lezar <elezar@nvidia.com> * Add curl to install instructions Signed-off-by: Evan Lezar <elezar@nvidia.com> * Update containerd and crio instructions for drop-in files Signed-off-by: Evan Lezar <elezar@nvidia.com> --------- Signed-off-by: Andrew Chen <andrewch@nvidia.com> Signed-off-by: Evan Lezar <elezar@nvidia.com> Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com> Co-authored-by: Evan Lezar <elezar@nvidia.com> Co-authored-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com> Co-authored-by: Abigail McCarthy <20771501+a-mccarthy@users.noreply.github.com> Signed-off-by: chenopis <andrewch@nvidia.com>
* initial draft of release notes and version updates Signed-off-by: Andrew Chen <andrewch@nvidia.com> * update release notes w/ feedback from elezar@ Signed-off-by: Andrew Chen <andrewch@nvidia.com> * Release note updates Signed-off-by: Evan Lezar <elezar@nvidia.com> * Add documentation for the systemd nvidia-container-toolkit.service (#203) Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com> * Update CDI service instructions Signed-off-by: Evan Lezar <elezar@nvidia.com> * fix typos Signed-off-by: Andrew Chen <andrewch@nvidia.com> * Changes for style guide compliance Signed-off-by: Andrew Chen <andrewch@nvidia.com> * Update container-toolkit/release-notes.md Co-authored-by: Abigail McCarthy <20771501+a-mccarthy@users.noreply.github.com> Signed-off-by: Evan Lezar <elezar@nvidia.com> * Add curl to install instructions Signed-off-by: Evan Lezar <elezar@nvidia.com> * Update containerd and crio instructions for drop-in files Signed-off-by: Evan Lezar <elezar@nvidia.com> --------- Signed-off-by: Andrew Chen <andrewch@nvidia.com> Signed-off-by: Evan Lezar <elezar@nvidia.com> Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com> Co-authored-by: Evan Lezar <elezar@nvidia.com> Co-authored-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com> Co-authored-by: Abigail McCarthy <20771501+a-mccarthy@users.noreply.github.com>
* initial draft of release notes and version updates Signed-off-by: Andrew Chen <andrewch@nvidia.com> * update release notes w/ feedback from elezar@ Signed-off-by: Andrew Chen <andrewch@nvidia.com> * Release note updates Signed-off-by: Evan Lezar <elezar@nvidia.com> * Add documentation for the systemd nvidia-container-toolkit.service (#203) Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com> * Update CDI service instructions Signed-off-by: Evan Lezar <elezar@nvidia.com> * fix typos Signed-off-by: Andrew Chen <andrewch@nvidia.com> * Changes for style guide compliance Signed-off-by: Andrew Chen <andrewch@nvidia.com> * Update container-toolkit/release-notes.md Co-authored-by: Abigail McCarthy <20771501+a-mccarthy@users.noreply.github.com> Signed-off-by: Evan Lezar <elezar@nvidia.com> * Add curl to install instructions Signed-off-by: Evan Lezar <elezar@nvidia.com> * Update containerd and crio instructions for drop-in files Signed-off-by: Evan Lezar <elezar@nvidia.com> --------- Signed-off-by: Andrew Chen <andrewch@nvidia.com> Signed-off-by: Evan Lezar <elezar@nvidia.com> Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com> Co-authored-by: Evan Lezar <elezar@nvidia.com> Co-authored-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com> Co-authored-by: Abigail McCarthy <20771501+a-mccarthy@users.noreply.github.com> Signed-off-by: chenopis <andrewch@nvidia.com>
* initial draft of release notes and version updates Signed-off-by: Andrew Chen <andrewch@nvidia.com> * update release notes w/ feedback from elezar@ Signed-off-by: Andrew Chen <andrewch@nvidia.com> * Release note updates Signed-off-by: Evan Lezar <elezar@nvidia.com> * Add documentation for the systemd nvidia-container-toolkit.service (#203) Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com> * Update CDI service instructions Signed-off-by: Evan Lezar <elezar@nvidia.com> * fix typos Signed-off-by: Andrew Chen <andrewch@nvidia.com> * Changes for style guide compliance Signed-off-by: Andrew Chen <andrewch@nvidia.com> * Update container-toolkit/release-notes.md Co-authored-by: Abigail McCarthy <20771501+a-mccarthy@users.noreply.github.com> Signed-off-by: Evan Lezar <elezar@nvidia.com> * Add curl to install instructions Signed-off-by: Evan Lezar <elezar@nvidia.com> * Update containerd and crio instructions for drop-in files Signed-off-by: Evan Lezar <elezar@nvidia.com> --------- Signed-off-by: Andrew Chen <andrewch@nvidia.com> Signed-off-by: Evan Lezar <elezar@nvidia.com> Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com> Co-authored-by: Evan Lezar <elezar@nvidia.com> Co-authored-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com> Co-authored-by: Abigail McCarthy <20771501+a-mccarthy@users.noreply.github.com> Signed-off-by: chenopis <andrewch@nvidia.com>
* Update openshift version to 25.3.4 (#282) Signed-off-by: Andrew Chen <andrewch@nvidia.com> Signed-off-by: chenopis <andrewch@nvidia.com> * Update Build the vGPU manager section ref (#266) Close #265 Signed-off-by: Michele Valsecchi <mvalsecchi@nvidia.com> Signed-off-by: chenopis <andrewch@nvidia.com> * migrate refrences from gitlab to github Signed-off-by: Shiva Kumar (SW-CLOUD) <shivaku@nvidia.com> Signed-off-by: chenopis <andrewch@nvidia.com> * Update README.md docker pull command Signed-off-by: Andrew Chen <andrewch@nvidia.com> Signed-off-by: chenopis <andrewch@nvidia.com> * Update the building of vgpu manager build doc Signed-off-by: Shiva Kumar (SW-CLOUD) <shivaku@nvidia.com> Signed-off-by: chenopis <andrewch@nvidia.com> * Minor changes for style guide compliance Signed-off-by: Andrew Chen <andrewch@nvidia.com> Signed-off-by: chenopis <andrewch@nvidia.com> * Container Toolkit 1.18.0 release notes (#242) * initial draft of release notes and version updates Signed-off-by: Andrew Chen <andrewch@nvidia.com> * update release notes w/ feedback from elezar@ Signed-off-by: Andrew Chen <andrewch@nvidia.com> * Release note updates Signed-off-by: Evan Lezar <elezar@nvidia.com> * Add documentation for the systemd nvidia-container-toolkit.service (#203) Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com> * Update CDI service instructions Signed-off-by: Evan Lezar <elezar@nvidia.com> * fix typos Signed-off-by: Andrew Chen <andrewch@nvidia.com> * Changes for style guide compliance Signed-off-by: Andrew Chen <andrewch@nvidia.com> * Update container-toolkit/release-notes.md Co-authored-by: Abigail McCarthy <20771501+a-mccarthy@users.noreply.github.com> Signed-off-by: Evan Lezar <elezar@nvidia.com> * Add curl to install instructions Signed-off-by: Evan Lezar <elezar@nvidia.com> * Update containerd and crio instructions for drop-in files Signed-off-by: Evan Lezar <elezar@nvidia.com> --------- Signed-off-by: Andrew Chen <andrewch@nvidia.com> Signed-off-by: Evan Lezar <elezar@nvidia.com> Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com> Co-authored-by: Evan Lezar <elezar@nvidia.com> Co-authored-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com> Co-authored-by: Abigail McCarthy <20771501+a-mccarthy@users.noreply.github.com> Signed-off-by: chenopis <andrewch@nvidia.com> * Add missing sudo when installing prerequisties (#290) Signed-off-by: Evan Lezar <elezar@nvidia.com> Signed-off-by: chenopis <andrewch@nvidia.com> * fix release 25.3.3 and 25.3.4 release notes (#289) Signed-off-by: Abigail McCarthy <20771501+a-mccarthy@users.noreply.github.com> Signed-off-by: chenopis <andrewch@nvidia.com> * add dgx spark to platform support page (#291) Signed-off-by: Abigail McCarthy <20771501+a-mccarthy@users.noreply.github.com> Signed-off-by: chenopis <andrewch@nvidia.com> * Temporarily remove Confidential Containers documentation (#258) Signed-off-by: Andrew Chen <andrewch@nvidia.com> Signed-off-by: chenopis <andrewch@nvidia.com> --------- Signed-off-by: Andrew Chen <andrewch@nvidia.com> Signed-off-by: chenopis <andrewch@nvidia.com> Signed-off-by: Michele Valsecchi <mvalsecchi@nvidia.com> Signed-off-by: Shiva Kumar (SW-CLOUD) <shivaku@nvidia.com> Signed-off-by: Evan Lezar <elezar@nvidia.com> Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com> Signed-off-by: Abigail McCarthy <20771501+a-mccarthy@users.noreply.github.com> Co-authored-by: mvalsecchi-nv <mvalsecchi@nvidia.com> Co-authored-by: Shiva Kumar <shiva@nvidia.com> Co-authored-by: Evan Lezar <elezar@nvidia.com> Co-authored-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com> Co-authored-by: Abigail McCarthy <20771501+a-mccarthy@users.noreply.github.com>
Preview: https://nvidia.github.io/cloud-native-docs/review/pr-242/container-toolkit/latest/index.html
Signed-off-by: Andrew Chen andrewch@nvidia.com