Repository navigation
Fix RST formatting and style guide compliance - #255
Merged
Merged
Conversation
Documentation preview |
chenopis
force-pushed
the
fix-install-gpu-ocp
branch
2 times, most recently
from
September 18, 2025 03:31
363a3ba to
c12f58e
Compare
Signed-off-by: Andrew Chen <andrewch@nvidia.com>
chenopis
force-pushed
the
fix-install-gpu-ocp
branch
from
September 18, 2025 03:41
c12f58e to
4d13790
Compare
Signed-off-by: Andrew Chen <andrewch@nvidia.com>
chenopis
force-pushed
the
fix-install-gpu-ocp
branch
from
September 18, 2025 03:55
b7f9add to
c0c5b23
Compare
Signed-off-by: Andrew Chen <andrewch@nvidia.com>
Signed-off-by: Andrew Chen <andrewch@nvidia.com>
Signed-off-by: Andrew Chen <andrewch@nvidia.com>
Signed-off-by: Andrew Chen <andrewch@nvidia.com>
chenopis
force-pushed
the
fix-install-gpu-ocp
branch
13 times, most recently
from
September 18, 2025 09:15
6e1ae30 to
f0bad74
Compare
Signed-off-by: Andrew Chen <andrewch@nvidia.com>
chenopis
force-pushed
the
fix-install-gpu-ocp
branch
from
September 18, 2025 09:18
f0bad74 to
a616759
Compare
Signed-off-by: Andrew Chen <andrewch@nvidia.com>
chenopis
force-pushed
the
fix-install-gpu-ocp
branch
from
September 18, 2025 09:39
3265e1e to
1c92c47
Compare
Signed-off-by: Andrew Chen <andrewch@nvidia.com>
chenopis
force-pushed
the
fix-install-gpu-ocp
branch
from
September 18, 2025 09:42
1c92c47 to
ec14c0a
Compare
chenopis
changed the title
mikemckiernan
approved these changes
Sep 18, 2025
mikemckiernan
left a comment
mikemckiernan
left a comment
Member
There was a problem hiding this comment.
Thanks so much for the care and time that you put into this PR. It's great to see the attention to detail.
I think you modified some of the same files in another PR. I didn't point out that new terms, like sandboxing and sandbox workloads are styled in italics because I shared it in the other review.
Signed-off-by: Andrew Chen <andrewch@nvidia.com>
chenopis
added a commit
that referenced
this pull request
Oct 2, 2025
* Fix RST formatting and style guide compliance Signed-off-by: Andrew Chen <andrewch@nvidia.com> * fix install-nfd.rst Signed-off-by: Andrew Chen <andrewch@nvidia.com> * fix mig-ocp.rst Signed-off-by: Andrew Chen <andrewch@nvidia.com> * fix nvaie-with-ocp.rst Signed-off-by: Andrew Chen <andrewch@nvidia.com> * fix mirror-gpu-ocp-disconnected.rst Signed-off-by: Andrew Chen <andrewch@nvidia.com> * fix more indentation syntax issues Signed-off-by: Andrew Chen <andrewch@nvidia.com> * more indentation fixes + pre-requisites -> prerequisites Signed-off-by: Andrew Chen <andrewch@nvidia.com> * more changes to match style guide Signed-off-by: Andrew Chen <andrewch@nvidia.com> * more indentation fixes Signed-off-by: Andrew Chen <andrewch@nvidia.com> * revert gpu-operator-kubevirt.rst Signed-off-by: Andrew Chen <andrewch@nvidia.com> --------- Signed-off-by: Andrew Chen <andrewch@nvidia.com>
chenopis
added a commit
that referenced
this pull request
Oct 2, 2025
* Fix RST formatting and style guide compliance Signed-off-by: Andrew Chen <andrewch@nvidia.com> * fix install-nfd.rst Signed-off-by: Andrew Chen <andrewch@nvidia.com> * fix mig-ocp.rst Signed-off-by: Andrew Chen <andrewch@nvidia.com> * fix nvaie-with-ocp.rst Signed-off-by: Andrew Chen <andrewch@nvidia.com> * fix mirror-gpu-ocp-disconnected.rst Signed-off-by: Andrew Chen <andrewch@nvidia.com> * fix more indentation syntax issues Signed-off-by: Andrew Chen <andrewch@nvidia.com> * more indentation fixes + pre-requisites -> prerequisites Signed-off-by: Andrew Chen <andrewch@nvidia.com> * more changes to match style guide Signed-off-by: Andrew Chen <andrewch@nvidia.com> * more indentation fixes Signed-off-by: Andrew Chen <andrewch@nvidia.com> * revert gpu-operator-kubevirt.rst Signed-off-by: Andrew Chen <andrewch@nvidia.com> --------- Signed-off-by: Andrew Chen <andrewch@nvidia.com> Signed-off-by: chenopis <andrewch@nvidia.com>
chenopis
added a commit
that referenced
this pull request
Oct 2, 2025
* Fix RST formatting and style guide compliance Signed-off-by: Andrew Chen <andrewch@nvidia.com> * fix install-nfd.rst Signed-off-by: Andrew Chen <andrewch@nvidia.com> * fix mig-ocp.rst Signed-off-by: Andrew Chen <andrewch@nvidia.com> * fix nvaie-with-ocp.rst Signed-off-by: Andrew Chen <andrewch@nvidia.com> * fix mirror-gpu-ocp-disconnected.rst Signed-off-by: Andrew Chen <andrewch@nvidia.com> * fix more indentation syntax issues Signed-off-by: Andrew Chen <andrewch@nvidia.com> * more indentation fixes + pre-requisites -> prerequisites Signed-off-by: Andrew Chen <andrewch@nvidia.com> * more changes to match style guide Signed-off-by: Andrew Chen <andrewch@nvidia.com> * more indentation fixes Signed-off-by: Andrew Chen <andrewch@nvidia.com> * revert gpu-operator-kubevirt.rst Signed-off-by: Andrew Chen <andrewch@nvidia.com> --------- Signed-off-by: Andrew Chen <andrewch@nvidia.com> Signed-off-by: chenopis <andrewch@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several major HTML formatting issues due to RST indentation syntax mistakes.
For example, visually compare: https://docs.nvidia.com/datacenter/cloud-native/openshift/25.3.2/install-gpu-ocp.html
with preview: https://nvidia.github.io/cloud-native-docs/review/pr-255/openshift/latest/install-gpu-ocp.html
Signed-off-by: Andrew Chen andrewch@nvidia.com