Stop requiring argument_type in bloom filter policy hashers - #825
Merged
PointKernel merged 1 commit intoJul 2, 2026
Merged
Conversation
PointKernel
added
topic: bloom_filter
sleeepyjack
approved these changes
Jul 2, 2026
3 tasks
rapids-bot Bot
pushed a commit
to NVIDIA/cudf
that referenced
this pull request
Jul 6, 2026
…23049) This PR migrates the Parquet reader and the streaming bloom filter onto cuco's new `parametric_filter_policy` (bumped via rapidsai/rapids-cmake#1044). The Parquet reader defines a local `arrow_filter_policy` alias hashing keys with `XXHash_64`, and streaming uses the policy directly with `identity_hash`; no shared cudf policy header is added. Depends on NVIDIA/cuCollections#825, which drops the hasher `argument_type` requirement so `XXHash_64` can be used without an adapter. Authors: - Yunsong Wang (https://github.com/PointKernel) Approvers: - Muhammad Haseeb (https://github.com/mhaseeb123) - Lawrence Mitchell (https://github.com/wence-) URL: #23049
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per rapidsai/cudf#23049 (comment),
parametric_filter_policyno longer readstypename Hash::argument_type:split_hashis templated on the key type and deduces everything from the actual call, so hashers without that alias (e.g. cudf'sXXHash_64) work directly.hash_result_typeis fixed touint64_twith the 64-bit assert moved intosplit_hash.