Add config option for JIT parquet filtering - #21460
Conversation
…rs/jit-parquet-filter
| duckdb_err = None | ||
| except ImportError as e: | ||
| duckdb = None | ||
| duckdb = None # type: ignore[assignment] |
There was a problem hiding this comment.
If you needed these locally, you possibly had duckdb installed in your mypy env, while CI doesn't.
You could maybe change this to type: ignore[assignment,unused-ignore]
…tt711/cudf into fea/polars/jit-parquet-filter
|
/ok to test 9c12fec |
|
/merge |
|
/ok to test 1790ac6 |
|
/ok to test 1a7cc96 |
|
/ok to test 6bc7595 |
|
@Matt711 if you can resolve conflicts this PR is probably ready to merge. |
|
/ok to test d6aed0a |
|
/merge |
|
/ok to test 8e5279e |
…uet-filter # Conflicts: # python/cudf_polars/cudf_polars/utils/config.py # python/cudf_polars/tests/test_parquet_filters.py
|
/ok to test 08e36db |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds a ChangesJIT Filter Configuration and Wiring
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Use executor='in-memory' to avoid triggering DefaultSingletonEngine, which wasn't being shut down before subsequent spmd-small tests could run on the same pytest-xdist worker.
|
/ok to test 6a3a2ab |
Explicitly pass encoding='utf-8' to path.open() in the CSV blank-line skip loop. Without this, the default encoding on systems with LANG=C (e.g. CI containers) is ASCII, which fails when the CSV file contains non-ASCII data (e.g. UTF-8 encoded strings).
|
/ok to test 0827b5e |
|
/ok to test c32dd63 |
|
/ok to test 31e672d |
|
/ok to test 518c903 |
|
/ok to test 49cc035 |
|
/ok to test 6446f9a |
Description
Adds an option to cudf-polars to to control whether parquet predicates are JIT compiled.
Contribute to #21456
Checklist