Use new rapidsmpf utilities to handle cancellation in bloom filter awaitables

[wence-]

Description

To avoid cancellation in python leading to attempting to set a result on an already cancelled Future, use the new pattern introduced in rapidsai/rapidsmpf#1131

Checklist

• I am familiar with the Contributing Guidelines.
• New or existing tests cover these changes.
• The documentation is up to date with these changes.

[copy-pr-bot]

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

[wence-]

/ok to test a49d788

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

📝 Walkthrough

Walkthrough

Changes

Bloom filter updates

Layer / File(s)	Summary
Device bloom filter stream handling cpp/libcudf_streaming/include/.../device_bloom_filter.hpp, cpp/libcudf_streaming/src/detail/device_bloom_filter.cu	Construction-time stream state and the stream() accessor were removed; storage alignment and caller-provided hashing resources were updated.
Bloom filter integration cpp/libcudf_streaming/src/bloom_filter.cpp	Build, merge, and apply paths construct stream-neutral filters and reserve device memory for hash values during build.
Python cancellation and regression coverage python/cudf_streaming/cudf_streaming/bloom_filter.pyx, python/cudf_streaming/cudf_streaming/tests/test_bloom_filter.py	Build and apply cancellation shuts down channels, with a test verifying output-channel closure after cancellation.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Possibly related PRs

• rapidsai/cudf#23067: Updates the device_bloom_filter construction API and related call sites while changing filter sizing behavior.

Suggested reviewers: msarahan

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 7.14% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: updated cancellation handling for bloom filter awaitables using rapidsmpf utilities.
Description check	✅ Passed	The description is directly related to the changes and explains the cancellation-future issue the patch addresses.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

🧹 Nitpick comments (1)

python/cudf_streaming/cudf_streaming/tests/test_bloom_filter.py (1)

175-223: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Add equivalent cancellation coverage for BloomFilter.apply.

The PR changes cancellation wiring for both async methods, but this regression test covers only build. Add an apply test that blocks, cancels, and verifies its bloom-filter/input/output channels are closed.

As per coding guidelines, “Add unit tests and unit benchmarks for code contributions.”

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@python/cudf_streaming/cudf_streaming/tests/test_bloom_filter.py` around lines
175 - 223, Add a cancellation regression test alongside
test_bloom_filter_build_timeout_cancellation for BloomFilter.apply that blocks
on its output, runs through run_actor_network until pytest-timeout cancellation,
and verifies the apply bloom-filter, input, and output channels are closed by
receiving None from each after cancellation. Reuse the existing Context,
Communicator, channel, and message setup patterns while covering the
apply-specific inputs and outputs.

Source: Coding guidelines

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@python/cudf_streaming/cudf_streaming/tests/test_bloom_filter.py`:
- Around line 175-223: Add a cancellation regression test alongside
test_bloom_filter_build_timeout_cancellation for BloomFilter.apply that blocks
on its output, runs through run_actor_network until pytest-timeout cancellation,
and verifies the apply bloom-filter, input, and output channels are closed by
receiving None from each after cancellation. Reuse the existing Context,
Communicator, channel, and message setup patterns while covering the
apply-specific inputs and outputs.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 504c0e19-0c5b-4f3d-8ecd-8796594f861a

📥 Commits

Reviewing files that changed from the base of the PR and between 7b13484 and 20a480c.

📒 Files selected for processing (7)

• cpp/libcudf_streaming/include/cudf_streaming/detail/device_bloom_filter.hpp
• cpp/libcudf_streaming/src/bloom_filter.cpp
• cpp/libcudf_streaming/src/detail/device_bloom_filter.cu
• dependencies.yaml
• python/cudf_streaming/cudf_streaming/bloom_filter.pyx
• python/cudf_streaming/cudf_streaming/tests/test_bloom_filter.py
• python/cudf_streaming/pyproject.toml

[TomAugspurger]

The python changes look good, though I have one question about the test.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@python/cudf_streaming/cudf_streaming/tests/test_bloom_filter.py`:
- Around line 204-220: Update the test around just_raise and bloom.build so the
RuntimeError is released only after a deterministic signal confirms the build
has reached its blocked ch_out-draining state, ensuring the test exercises
cancellation of that blocked worker. Rename the timeout-oriented comment to
describe exception-driven cancellation, and retain coverage for the resulting
exception group.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: bfad6dab-76d5-47ec-a59b-6524a59a4e4e

📥 Commits

Reviewing files that changed from the base of the PR and between 20a480c and fba2372.

📒 Files selected for processing (5)

• cpp/libcudf_streaming/include/cudf_streaming/detail/device_bloom_filter.hpp
• cpp/libcudf_streaming/src/bloom_filter.cpp
• cpp/libcudf_streaming/src/detail/device_bloom_filter.cu
• python/cudf_streaming/cudf_streaming/bloom_filter.pyx
• python/cudf_streaming/cudf_streaming/tests/test_bloom_filter.py

🚧 Files skipped from review as they are similar to previous changes (3)

• python/cudf_streaming/cudf_streaming/bloom_filter.pyx
• cpp/libcudf_streaming/include/cudf_streaming/detail/device_bloom_filter.hpp
• cpp/libcudf_streaming/src/detail/device_bloom_filter.cu

[wence-]

This needs new 26.08 packages to be released, but the publishing process appears broken

[coderabbitai]

🧹 Nitpick comments (1)

python/cudf_streaming/cudf_streaming/bloom_filter.pyx (1)

212-216: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Document cancellation side effects in both public methods.

build cancellation now shuts down ch_in/ch_out, while apply also shuts down bloom_filter; document these effects and the None return value in the adjacent docstrings.

As per coding guidelines, public API methods must document parameters, return values, and behavior.

Also applies to: 256-258

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@python/cudf_streaming/cudf_streaming/bloom_filter.pyx` around lines 212 -
216, Update the adjacent docstrings for both public methods, build and apply, to
document their parameters, that cancellation returns None, and the cancellation
side effects: build shuts down ch_in and ch_out, while apply additionally shuts
down bloom_filter. Preserve the existing method behavior and describe these
effects in the public API documentation.

Source: Coding guidelines

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@python/cudf_streaming/cudf_streaming/bloom_filter.pyx`:
- Around line 212-216: Update the adjacent docstrings for both public methods,
build and apply, to document their parameters, that cancellation returns None,
and the cancellation side effects: build shuts down ch_in and ch_out, while
apply additionally shuts down bloom_filter. Preserve the existing method
behavior and describe these effects in the public API documentation.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 73c8a4db-e422-4020-967a-e6f1d32512a8

📥 Commits

Reviewing files that changed from the base of the PR and between 2892e1e and 5b68103.

📒 Files selected for processing (5)

• cpp/libcudf_streaming/include/cudf_streaming/detail/device_bloom_filter.hpp
• cpp/libcudf_streaming/src/bloom_filter.cpp
• cpp/libcudf_streaming/src/detail/device_bloom_filter.cu
• python/cudf_streaming/cudf_streaming/bloom_filter.pyx
• python/cudf_streaming/cudf_streaming/tests/test_bloom_filter.py

🚧 Files skipped from review as they are similar to previous changes (4)

• cpp/libcudf_streaming/include/cudf_streaming/detail/device_bloom_filter.hpp
• python/cudf_streaming/cudf_streaming/tests/test_bloom_filter.py
• cpp/libcudf_streaming/src/bloom_filter.cpp
• cpp/libcudf_streaming/src/detail/device_bloom_filter.cu

[TomAugspurger]

I merged release/26.08 in f494cbb to pick up the other CI changes.

[TomAugspurger]

/merge