Skip to content

Remove deprecated key_remapping and filter_join_indices APIs - #23476

Merged
rapids-bot[bot] merged 2 commits into
NVIDIA:mainfrom
PointKernel:agent/remove-deprecated-join-apis
Aug 3, 2026
Merged

Remove deprecated key_remapping and filter_join_indices APIs#23476
rapids-bot[bot] merged 2 commits into
NVIDIA:mainfrom
PointKernel:agent/remove-deprecated-join-apis

Conversation

@PointKernel

Copy link
Copy Markdown
Member

Description

This PR removes the deprecated KEY_REMAP_BUILD_NULL, remap_build_keys, and remap_probe_keys key-remapping aliases and the deprecated filter_join_indices overload without output_size.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot

copy-pr-bot Bot commented Jul 29, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@PointKernel

Copy link
Copy Markdown
Member Author

/ok to test 1bd1c81

@PointKernel PointKernel added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Jul 29, 2026
@github-actions github-actions Bot added the libcudf Affects libcudf (C++/CUDA) code. label Jul 29, 2026
@PointKernel

Copy link
Copy Markdown
Member Author

/ok to test 9e9e371

@PointKernel
PointKernel marked this pull request as ready for review July 30, 2026 04:44
@PointKernel
PointKernel requested a review from a team as a code owner July 30, 2026 04:44
@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 97f35ae3-8f49-42c5-bf7d-d0d536169d04

📥 Commits

Reviewing files that changed from the base of the PR and between d466e60 and 9e9e371.

📒 Files selected for processing (3)
  • cpp/include/cudf/join/join.hpp
  • cpp/include/cudf/join/key_remapping.hpp
  • cpp/src/join/filter_join_indices/filter_join_indices.cu
💤 Files with no reviewable changes (3)
  • cpp/src/join/filter_join_indices/filter_join_indices.cu
  • cpp/include/cudf/join/key_remapping.hpp
  • cpp/include/cudf/join/join.hpp

📝 Walkthrough

Summary by CodeRabbit

  • API Updates
    • Updated filtered join index operations to accept an optional output-size limit.
    • Removed deprecated join key remapping aliases and methods; use the current right/left key remapping APIs instead.
    • Removed the deprecated filtered join overload in favor of the updated interface.

Walkthrough

Changes

Join API updates

Layer / File(s) Summary
Filter join output sizing
cpp/include/cudf/join/join.hpp, cpp/src/join/filter_join_indices/filter_join_indices.cu
filter_join_indices accepts an optional output_size and forwards it to the detail implementation.
Deprecated key remapping removal
cpp/include/cudf/join/key_remapping.hpp
Removes KEY_REMAP_BUILD_NULL, remap_build_keys, and remap_probe_keys.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: mhaseeb123, bdice, vyasr

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the removal of deprecated key_remapping and filter_join_indices APIs.
Description check ✅ Passed The description directly matches the changes by listing the removed deprecated aliases and overload.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@PointKernel

Copy link
Copy Markdown
Member Author

/merge

@rapids-bot
rapids-bot Bot merged commit 197f487 into NVIDIA:main Aug 3, 2026
135 of 136 checks passed
@PointKernel
PointKernel deleted the agent/remove-deprecated-join-apis branch August 3, 2026 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants