Remove bloom prefilter application in cudf-polars streaming - #23523
Conversation
We are going to use the new filterpushdown hint nodes to handle this more coherently.
72a96a8 to
4dff822
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (7)
💤 Files with no reviewable changes (4)
📝 WalkthroughSummary by CodeRabbit
WalkthroughDynamic-planning joins no longer allocate or execute Bloom-filter prefiltering. Related configuration, tracing metadata propagation, and tests were removed or updated. ChangesDynamic join prefilter removal
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
| sample_chunk_count | ||
| The maximum number of chunks to sample before making | ||
| dynamic-planning decisions. Default is 2. | ||
| join_prefilter_threshold |
There was a problem hiding this comment.
I think this is fine, but just flagging that this configuration change is breaking (at least currently, perhaps the subsequent PR will restore this though I'd guess it'll use different names).
|
/merge |
Description
If join filter pushdown is applied, additionally applying a bloom filter does additional work for no benefit. Bloom filters are also only on immediate local inputs to a join.
In an upcoming change we will change the join filter pushdown to be a hint that can at runtime decide how to apply itself. To prepare for that, remove the special case code that just applies bloom filters: it will be subsumed by the upcoming changes.
Checklist