Skip to content

Use new constraints type from DFG - #23556

Open
KyleFromNVIDIA wants to merge 1 commit into
NVIDIA:mainfrom
KyleFromNVIDIA:use-dfg-constraints
Open

Use new constraints type from DFG#23556
KyleFromNVIDIA wants to merge 1 commit into
NVIDIA:mainfrom
KyleFromNVIDIA:use-dfg-constraints

Conversation

@KyleFromNVIDIA

Copy link
Copy Markdown
Member

Description

As of rapids-dependency-file-generator v1.22.0, a new output type, constraints, is supported, allowing constraints to be separated from requirements. Use this where possible.

For now, be overzealous in turning on constraints wherever requirements is used. If we ever run into issues with constraints having extras, we can deal with it at that time.

Contributes to rapidsai/build-planning#311

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

As of rapids-dependency-file-generator v1.22.0, a new output type,
`constraints`, is supported, allowing constraints to be separated
from requirements. Use this where possible.

For now, be overzealous in turning on `constraints` wherever
`requirements` is used. If we ever run into issues with constraints
having extras, we can deal with it at that time.

Contributes to rapidsai/build-planning#311
@KyleFromNVIDIA KyleFromNVIDIA added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 5, 2026
@KyleFromNVIDIA
KyleFromNVIDIA requested review from a team as code owners August 5, 2026 19:05
@KyleFromNVIDIA
KyleFromNVIDIA requested a review from gforsyth August 5, 2026 19:05
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: b1e3bbf4-0fad-4a96-b38b-2eabffd34fdc

📥 Commits

Reviewing files that changed from the base of the PR and between 6cde5e1 and 6f8067c.

📒 Files selected for processing (8)
  • .pre-commit-config.yaml
  • ci/cudf_pandas_scripts/run_tests.sh
  • ci/test_cudf_polars_polars_tests.sh
  • ci/test_wheel_cudf.sh
  • ci/test_wheel_cudf_polars.sh
  • ci/test_wheel_cudf_streaming.sh
  • ci/test_wheel_dask_cudf.sh
  • dependencies.yaml

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes

    • Improved generation and placement of Python dependency constraints across build, runtime, testing, CUDA, and compatibility configurations.
    • Updated continuous integration checks to consistently use the generated constraints, improving dependency resolution and test reliability.
    • Corrected pip dependency output handling, including package and extra-index configuration.
  • Chores

    • Updated dependency-generation tooling.
    • Refreshed copyright notices through 2026.

Walkthrough

Changes

Constraints output generation

Layer / File(s) Summary
Dependency output declarations
.pre-commit-config.yaml, dependencies.yaml
The dependency-file-generator uses v1.22.0. Build and runtime groups now include constraints outputs.
Testing and specialized dependency outputs
dependencies.yaml
Testing, package, compatibility, index, Ray, and Dask CUDA groups now emit constraints outputs with updated pip mappings.
CI constraints generation wiring
ci/*.sh
CI scripts pass constraints to rapids-generate-pip-constraints. Selected SPDX notices include affiliates and 2026.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Possibly related PRs

  • rapidsai/cudf#23305: Updates dependency-generation configuration in a related dependency configuration change.
  • rapidsai/cudf#23339: Contains a successive update to the dependency-file-generator revision.
  • rapidsai/cudf#23516: Contains related depends_on_dask_cuda pip constraints changes.

Suggested labels: Python, cudf-polars

Suggested reviewers: vyasr, gforsyth, msarahan

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the primary change: adopting the new constraints output type from the dependency file generator.
Description check ✅ Passed The description directly explains the constraints output changes and identifies the related dependency file generator update.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant