-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[PERF]: Improve the performance of plc.io.parquet.read_parquet with prefetched parquet file metadata.
#23558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TomAugspurger
wants to merge
33
commits into
NVIDIA:main
Choose a base branch
from
TomAugspurger:tom/parquet-metadata-gil-perf
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
17794d7
[PERF]: Avoid deep copies with GIL in pylibcudf read_parquet_footers
TomAugspurger ecfd5b6
Attempt to reduce GIL contention in Scan nodes.
TomAugspurger b3775f5
Option to skip page index materialization in parquet metadata
TomAugspurger f5525b5
Enable prefetching by default
TomAugspurger 0053fb4
test style
TomAugspurger fd8ce79
Merge branch 'main' into tom/parquet-metadata-gil-perf
TomAugspurger 3491475
prefetch only parquet types
TomAugspurger c076a1e
Executor-dependent default
TomAugspurger a8bb6fb
user option fixes
TomAugspurger 5b6717f
fix
TomAugspurger 14f7258
disable for use_rapidsmpf_native
TomAugspurger 77f3793
merge conflict
Matt711 fe11cd9
Merge branch 'main' into tom/parquet-metadata-gil-perf
Matt711 aebf8a0
revert commit 3: dont read page indices
Matt711 f9490ac
move helper function from C++ to Cython (verbatim)
Matt711 5e864ac
properly handle unspecified prefetch meta in parquet options
Matt711 3c1d78b
turn on for cloud-only
Matt711 98fbdd8
Merge branch 'main' into tom/parquet-metadata-gil-perf
Matt711 93bccd7
pre-commit
Matt711 df0b4d4
remove copyright change
Matt711 8b7563a
Merge branch 'main' into tom/parquet-metadata-gil-perf
Matt711 ad20e44
default is Unspecified for prefetching with streaming engine
Matt711 74cda45
add a test for ParquetOptions w/o setting prefetching default
Matt711 0af3e32
fix tests because we fallback now if metadata is not prefetched
Matt711 4c55108
test remote_only=True
Matt711 071bd04
docs, small fixes
Matt711 ea351a6
revert unnecessary changes
Matt711 d84b230
remove copy_parquet_metadatas
Matt711 420469a
more doc strings fixes
Matt711 813740f
trigger github update
Matt711 b545203
Merge branch 'main' into tom/parquet-metadata-gil-perf
Matt711 ccb3154
Merge branch 'main' into tom/parquet-metadata-gil-perf
Matt711 cdb65fe
Merge branch 'main' into tom/parquet-metadata-gil-perf
Matt711 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.