-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add opt-in per-row status column to VARIANT extraction and cast APIs #23560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
abigalekim
wants to merge
39
commits into
NVIDIA:main
Choose a base branch
from
abigalekim:ak/variant-status
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
c93ec2e
first commit of status opt in feature
abigalekim 78bbb90
refactor
abigalekim 11029ea
Update cpp/src/io/parquet/experimental/variant_extract.cu
abigalekim b6a421d
Update cpp/src/io/parquet/experimental/variant_extract.cu
abigalekim 7f339cf
reviews
abigalekim 3b57150
Merge branch 'main' into ak/variant-status
abigalekim dd35bee
Merge branch 'main' into ak/variant-status
abigalekim a41e516
reviews
abigalekim f018976
removing redundant things & comments
abigalekim 93f2cac
Merge main into ak/variant-status, resolve conflicts
abigalekim 5d22976
combing
abigalekim 2345cd4
comments
abigalekim 2935ba6
stuff
abigalekim f28e126
extract combing
abigalekim 59769ad
Merge branch 'main' into ak/variant-status
vuule d901a02
changes
abigalekim 3120d9f
Merge branch 'ak/variant-status' of github.com:abigalekim/cudf into a…
abigalekim 54c720a
changes
abigalekim d24b074
Merge branch 'main' into ak/variant-status
abigalekim 207742d
reviews
abigalekim 49e7e41
Merge branch 'ak/variant-status' of github.com:abigalekim/cudf into a…
abigalekim 639acc3
addressing comments
abigalekim 3cb0e7f
reviews
abigalekim d07f24f
changes
abigalekim f743b73
Merge branch 'main' into ak/variant-status
abigalekim bcd3083
changes
abigalekim bd75903
Merge branch 'ak/variant-status' of github.com:abigalekim/cudf into a…
abigalekim 5ca368d
Merge branch 'main' into ak/variant-status
abigalekim 3f316bf
reviews
abigalekim d00a0c3
Merge branch 'ak/variant-status' of github.com:abigalekim/cudf into a…
abigalekim ca3d7d5
Merge branch 'main' into ak/variant-status
abigalekim ee46adc
Merge branch 'main' into ak/variant-status
abigalekim f2b8a52
reviews
abigalekim ac26f90
Merge branch 'ak/variant-status' of github.com:abigalekim/cudf into a…
abigalekim ada04d9
Merge branch 'main' into ak/variant-status
abigalekim 62e3319
Update cpp/src/io/parquet/experimental/variant_extract.cu
abigalekim 7746e8f
Merge branch 'main' into ak/variant-status
abigalekim c239a0a
fixing comments
abigalekim 41e84ed
Merge branch 'ak/variant-status' of github.com:abigalekim/cudf into a…
abigalekim File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This signature change breaks the existing JNI call sites. Could you update the three calls in VariantUtilsJni.cpp in this PR by passing explicit nullptr arguments for the new status parameters?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will re-run CI to make sure the code works but I did edit VariantUtilsJni.cpp to reflect this.