-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[cudf] Adding memory_resources support for column wrappers
#23581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rapids-bot
merged 26 commits into
NVIDIA:main
from
nirandaperera:test-column-wrappers-mr
Aug 14, 2026
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
d11a8bb
Port column wrappers to accept memory_resources and stream
nirandaperera 3f518af
fix wrapper tests
nirandaperera cb35fb0
fix col util tests
nirandaperera 4a02ab8
fix ctrs
nirandaperera 4d2d6b8
Merge branch 'main' of github.com:rapidsai/cudf into test-column-wrap…
nirandaperera 8479c3d
precommit
nirandaperera 20eddfd
remove defaults
nirandaperera 2e4d5a8
code rabbit suggestions
nirandaperera 32b153d
addng failing default mr
nirandaperera 3cab3a6
fix ctr
nirandaperera b839630
Merge branch 'main' of github.com:rapidsai/cudf into test-column-wrap…
nirandaperera 19857eb
fix test with todo
nirandaperera 877ffc3
Merge branch 'main' of github.com:rapidsai/cudf into test-column-wrap…
nirandaperera cd3466f
simplify empty ctrs
nirandaperera e3cc3db
rename util
nirandaperera 40155c3
Apply suggestion from @bdice
nirandaperera f4293ad
moving base fixture & use concepts
nirandaperera 25e3b24
Merge branch 'test-column-wrappers-mr' of github.com:nirandaperera/cu…
nirandaperera e701a38
Merge branch 'main' of github.com:NVIDIA/cudf into test-column-wrappe…
nirandaperera 1a5fa38
precommit
nirandaperera aa0742e
Merge branch 'main' into test-column-wrappers-mr
bdice 58544b7
addressing bdice concerns
nirandaperera 00ef7bd
Merge branch 'test-column-wrappers-mr' of github.com:nirandaperera/cu…
nirandaperera c7a70e3
Merge branch 'main' into test-column-wrappers-mr
nirandaperera 47c4eb4
trigger build
nirandaperera 128c1c9
Merge branch 'test-column-wrappers-mr' of github.com:nirandaperera/cu…
nirandaperera File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't seem like this is included in #23027. Is this a requirement to get to the
cudf::label_binspilot, or is this additional scope? Either way we should make sure it's tracked in the issue.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its already drafted #23617
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need the comparators and preprocessed table changes, to fully make the column utils like
CUDF_TEST_EXPECT_COLUMNS_EQUALfree from current resource.