Fix how build.sh determines CUDA version - #23588
Merged
rapids-bot[bot] merged 4 commits intoAug 7, 2026
Merged
Conversation
In NVIDIA#23472, we incorrectly used `RAPIDS_CUDA_VERSION` in `build.sh`. This variable comes from CI only and should not be required to build locally. Determine the CUDA version in a similar manner to rapids-build-backend: run `nvcc --version` and parse the output. Fixes NVIDIA#23587
jameslamb
approved these changes
Aug 7, 2026
📝 WalkthroughSummary by CodeRabbit
Walkthrough
ChangesCUDA version configuration
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@build.sh`:
- Around line 66-67: Validate CUDA_VERSION immediately after the nvcc parsing
assignment: detect nvcc command failure and an empty parsed value, then
terminate the build with a clear error before the RAPIDS matrix configuration
uses it. Preserve the existing version extraction behavior for valid nvcc
output.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 89a2a2e3-12d7-47d3-9a89-b1d6698409dc
📒 Files selected for processing (1)
build.sh
Member
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In #23472, we incorrectly used
RAPIDS_CUDA_VERSIONinbuild.sh. This variable comes from CI only and should not be required to build locally. IfRAPIDS_CUDA_VERSIONis not available, determine the CUDA version in a similar manner to rapids-build-backend: runnvcc --versionand parse the output.Fixes #23587
Checklist