Skip to content

Fix index misalignment in char_wb ngram padding #8429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adityaanikam wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix index misalignment in char_wb ngram padding #8429

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions python/cuml/cuml/feature_extraction/_vectorizers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,11 +213,15 @@ def get_char_ngrams(self, ngram_size, str_series, doc_id_sr):
tokens = str_series.str.tokenize(self.delimiter)
del str_series

padding = Series(self.delimiter).repeat(len(tokens))
# tokens keeps the original per-document index (repeated per
# token); reset both to a plain range first so the two str.cat()
# calls below align positionally instead of by that index.
tokens = tokens.reset_index(drop=True)
padding = Series(self.delimiter).repeat(len(tokens)).reset_index(
drop=True
)
tokens = tokens.str.cat(padding)
padding = padding.reset_index(drop=True)
tokens = padding.str.cat(tokens)
tokens = tokens.reset_index(drop=True)

ngram_sr = tokens.str.character_ngrams(n=ngram_size)

Expand Down
Loading