Enable security scanning via NVIDIA/security-workflows suite - #2430
Open
gmanal wants to merge 3 commits into
Open
Enable security scanning via NVIDIA/security-workflows suite#2430gmanal wants to merge 3 commits into
gmanal wants to merge 3 commits into
Conversation
Call the centrally maintained security suite rather than wiring each scan separately: one pinned reference runs the Pulse secret scan and CodeQL SAST. Every scan in the suite is opt-in, so scanners added upstream later do not switch themselves on here. SAST analyzes python and actions. Both need no toolchain (build-mode none), so they add no build cost and no dependency on the CUDA/conda toolchain. actions matters here because labeler.yml and trigger-breaking-change-alert.yaml run on pull_request_target. c-cpp, java-kotlin, rust and go all need a working build to produce a database and are left out deliberately. Add the secret-scan-trufflehog pre-commit hook as the local advisory layer; the Pulse scan is the server-side enforcement layer.
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
gmanal
marked this pull request as ready for review
August 12, 2026 05:30
cjnolet
added
improvement
jameslamb
requested changes
Aug 12, 2026
jameslamb
left a comment
jameslamb
left a comment
Member
There was a problem hiding this comment.
Left some comments for your consideration.
| # strict — fail on any finding (verified or unverified) | ||
| # all — warn only; never fail the job on findings | ||
| secret-failure-policy: unverified | ||
| sast-languages: '["python","actions"]' |
Member
There was a problem hiding this comment.
Suggested change
| sast-languages: '["python","actions"]' | |
| sast-languages: '["actions","python"]' |
Let's alphabetize this, please.
Also, I couldn't find documentation on the available options for this at https://github.com/NVIDIA/security-workflows ... are there more?
This repo has Bash, C++, Go, Java, and Rust code too.
Author
There was a problem hiding this comment.
added java and rust to the scan list.
Go can't be analyzed buildless and would force a build mode Rust rejects; C++ is mostly CUDA, which CodeQL cannot parse at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Onboards cuVS to NVIDIA's centrally maintained security scanning via
NVIDIA/security-workflows, pinned tov0.3.0.Two layers, no new tooling for this repo to maintain:
secret-scan-trufflehogpre-commit hook, self-installing, pinned by tag like the repo's other hooks.Both scans are enabled explicitly in the new workflow, and every scan in the suite is opt-in — scanners added upstream later won't switch themselves on here.
Changes
.github/workflows/security-suite.yml— on pushes tomain,release/*, and copy-pr-botpull-request/[0-9]+, matchingbuild.yaml/pr.yaml. Uses this repo's permissions style (permissions: {}at workflow level, granted on the job) and thelinux-amd64-cpu4label already used bytelemetry-summarize..pre-commit-config.yaml— add the hook,rev: v0.3.0.SAST scope:
python+actions. Both run under CodeQLbuild-mode: none, so no toolchain and no added build time.actionsearns its place: 9 workflows, two onpull_request_target.Notes for Reviewers
How I tested this
pre-commit runon both changed files — passes, includingzizmor,yamllint,verify-copyright.pre-commit run --all-files secret-scan-trufflehog— clean across the tree. (v0.3.0excludes TruffleHog's Lob detector, which readstest_+ 35 chars as an API key and flagged pytest names as verified secrets elsewhere — hence this pin, not an earlier one.)