V2 devel: features to check option types #84
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the service container's option handling to use an interface-based approach, improving type safety and extensibility. The main changes include replacing the function-based
Optiontype with an interface, introducing option kind identification, and adding helper functions for option type checking.Refactoring Option Handling
Optiontype from a function to an interface withapplyandkindmethods, allowing for more structured and extensible option management. (container.go)NewFactory,NewService, andNewEntrypointto return the newOptioninterface, and replaced direct function returns with anewOptionconstructor that sets the option kind. (container.go) [1] [2] [3] [4] [5]Option Type Identification
IsFactory,IsService, andIsEntrypointto check the kind of an option, improving clarity and usability when working with different option types. (container.go,README.md) [1] [2]Internal Implementation Improvements
optionstruct to implement theOptioninterface, encapsulating the option logic and kind string. (container.go)applymethod for registering options, replacing direct function calls. (container.go)These changes make the service container more robust and easier to extend with new option types in the future.