V2 devel: options interface improvement #85
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors how options are handled in the service container by changing the
Optiontype from a function to an interface with anapplymethod. This enables a more extensible and object-oriented approach to option management. The changes affect both the core container logic and related tests, ensuring all option usages now call theapplymethod.Core API changes:
Optiontype incontainer.gofrom a function to an interface with anapplymethod, and updated all usages to callapplyinstead of invoking the function directly. [1] [2]optionstruct andnewOptionhelper function to implement the newOptioninterface and encapsulate option logic.Factory and service registration:
NewFactory,NewService, andNewEntrypointto return anOptioninstance using the new interface, and updated error messages for consistency. [1] [2] [3] [4] [5] [6]Test updates:
factory_test.goandregistry_test.goto call theapplymethod instead of invoking the function directly, ensuring compatibility with the new interface. [1] [2] [3] [4] [5] [6] [7] [8] [9]