refactor(rms-client)!: migrate to updated RMS proto#1944
Open
jayzhudev wants to merge 2 commits into
Open
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
jayzhudev
force-pushed
the
refactor/rms-proto
branch
3 times, most recently
from
8d5f7e5 to
1ae54f7
Compare
jayzhudev
force-pushed
the
refactor/rms-proto
branch
2 times, most recently
from
ded7c42 to
d53fff4
Compare
jayzhudev
force-pushed
the
refactor/rms-proto
branch
from
d53fff4 to
fc590a7
Compare
## Description Migrates NICo to the updated `nv-rms-client` proto. This covers the RMS RPC/type renames, enum updates, node/job field changes, and the related mock/test updates. It also preserves the old TLS behavior by mapping `verify_ssl: false` to endpoint-level `dangerously_accept_invalid_certs: true` where the proto refactor moved that setting. ## Type of Change <!-- Check one that best describes this PR --> - [ ] **Add** - New feature or capability - [ ] **Change** - Changes in existing functionality - [ ] **Fix** - Bug fixes - [ ] **Remove** - Removed features or deprecated functionality - [x] **Internal** - Internal changes (refactoring, tests, docs, etc.) ## Breaking Changes - [x] This PR contains breaking changes Updates the pinned `nv-rms-client` proto version, so downstream RMS needs to be updated to be compatible. ## Testing - [x] Unit tests added/updated - [ ] Integration tests added/updated - [ ] Manual testing performed - [ ] No testing required (docs, internal refactor, etc.) Signed-off-by: Jay Zhu <jayzhu@nvidia.com>
jayzhudev
force-pushed
the
refactor/rms-proto
branch
from
fc590a7 to
a749fb5
Compare
Signed-off-by: Jay Zhu <jayzhu@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrates NICo to the updated
nv-rms-clientproto.This covers the RMS RPC/type renames, enum updates, node/job field changes, and the related mock/test updates. It also preserves the old TLS behavior by mapping
verify_ssl: falseto endpoint-leveldangerously_accept_invalid_certs: truewhere the proto refactor moved that setting.Type of Change
Breaking Changes
Updates the pinned
nv-rms-clientproto version, so downstream RMS needs to be updated to be compatible.Testing