fix: split NMX-C partition IDs from NMX-M IDs#1950
Open
tmcroberts97 wants to merge 1 commit into
Open
Conversation
Add a dedicated nmx_c_partition_id column for physical NVLink partitions, and remove the NOT NULL constraint on the nmx_m_id column. NMX-C-created partitions will no longer make use of the legacy column. Also, update the monitor to build the DB partition map based on the new NMX-C ID column instead of parsing nmx_m_id. When a partition is successfully created or updated, delete any legacy partition rows in the DB from the same logical partition and nvlink domain. Signed-off-by: Thomas McRoberts <tmcroberts@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a dedicated nmx_c_partition_id column for physical NVLink partitions, and remove the NOT NULL constraint on the nmx_m_id column. NMX-C-created partitions will no longer make use of the legacy column.
Also, update the monitor to build the DB partition map based on the new NMX-C ID column instead of parsing nmx_m_id. When a partition is successfully created or updated, delete any legacy partition rows in the DB from the same logical partition and nvlink domain.
Description
Type of Change
Related Issues (Optional)
Breaking Changes
Testing
Additional Notes