Skip to content

fix: skip SSH host-key verification for BMC/DPU commands#1951

Merged
krish-nvidia merged 1 commit into
NVIDIA:mainfrom
krish-nvidia:fix-ssh-known-hosts
May 28, 2026
Merged

fix: skip SSH host-key verification for BMC/DPU commands#1951
krish-nvidia merged 1 commit into
NVIDIA:mainfrom
krish-nvidia:fix-ssh-known-hosts

Conversation

@krish-nvidia
Copy link
Copy Markdown
Contributor

Description

The russh 0.60.2 update (#1439) replaced async-ssh2-tokio's ServerCheckMethod::NoCheck with a hard check against ~/.ssh/known_hosts, which broke ssh commands issued by the BFB copy to DPU rshim functionality.

This PR adds a HostKeyVerification enum with an Insecure variant and uses it for the BMC/DPU rshim ops. libmlx's firmware SSH source keeps its previous behavior (verify against the default known_hosts).

Type of Change

  • Add - New feature or capability
  • Change - Changes in existing functionality
  • Fix - Bug fixes
  • Remove - Removed features or deprecated functionality
  • Internal - Internal changes (refactoring, tests, docs, etc.)

Related Issues (Optional)

NVBug-6208024

Breaking Changes

  • This PR contains breaking changes

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • No testing required (docs, internal refactor, etc.)

Additional Notes

Signed-off-by: Krish Dandiwala <kdandiwala@nvidia.com>
@krish-nvidia krish-nvidia requested review from kensimon and poroh May 27, 2026 15:38
@krish-nvidia krish-nvidia self-assigned this May 27, 2026
@krish-nvidia krish-nvidia requested a review from a team as a code owner May 27, 2026 15:38
@krish-nvidia krish-nvidia merged commit 51f4a9b into NVIDIA:main May 28, 2026
53 checks passed
@krish-nvidia krish-nvidia deleted the fix-ssh-known-hosts branch May 28, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants